Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation observer API #16190

Closed
wants to merge 23 commits into from
+612 −452
Closed

Mutation observer API #16190

Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
73f2c6e
Initial Files for MutationObserverAPI
srivassumit Mar 16, 2017
bee1340
add a vector of MutationObserver objects as a member of ScriptThread
srivassumit Mar 16, 2017
a5af9a2
Merge branch 'master' of https://github.com/servo/servo into Mutation…
srivassumit Mar 16, 2017
4ec5d92
Merge branch 'master' of https://github.com/servo/servo into Mutation…
srivassumit Mar 17, 2017
16c09d4
incomplete code for mutationobserver and mutationrecord
srivassumit Mar 20, 2017
e162f8a
fixed build errors, Constructor is pending
srivassumit Mar 21, 2017
b0af820
Resolving merge conflicts
krishnakarthick1993 Mar 23, 2017
8e6d4e9
added Mutation Observer Constructor
srivassumit Mar 29, 2017
4797cc3
Merge branch 'MutationObserver-dev' of https://github.com/srivassumit…
srivassumit Mar 29, 2017
dd9ea19
Merge branch 'master' of https://github.com/servo/servo into Mutation…
srivassumit Mar 29, 2017
4db8c26
changes for constructor
srivassumit Mar 30, 2017
1a7e2d4
Merge branch 'master' of https://github.com/servo/servo into Mutation…
srivassumit Mar 30, 2017
ef51869
Update mutationrecord.rs
srivassumit Mar 31, 2017
2d10eb7
Update script_thread.rs
srivassumit Mar 31, 2017
3dd78ed
more changes as per review comments
srivassumit Apr 1, 2017
0160982
fixed test test-tidy issues, accessed ScriptThread from mutationobserver
srivassumit Apr 1, 2017
eefb95b
Merge branch 'master' of https://github.com/servo/servo into Mutation…
srivassumit Apr 1, 2017
2cce8c5
modifications for review comments
srivassumit Apr 5, 2017
7115abd
Merge branch 'master' of https://github.com/servo/servo into Mutation…
srivassumit Apr 5, 2017
2821def
changes as per review comments
srivassumit Apr 5, 2017
a82e79d
Merge branch 'master' of https://github.com/servo/servo into Mutatio…
srivassumit Apr 5, 2017
3bd4438
removed unused imports and fixed review comments.
srivassumit Apr 5, 2017
c6739ef
removed unused import
srivassumit Apr 5, 2017
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

1 servo
Open in desktop
Submodule servo added at 1842b2
2 ...s/wpt/metadata/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html.ini
View file
Open in desktop
@@ -1,5 +1,5 @@
[contenttype_datauri_01.html]
type: testharness
[Data URI document.contentType === 'text/plain' when data URI MIME type is not set]
expected: FAIL
expected: TIMEOUT

2 ...s/wpt/metadata/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html.ini
View file
Open in desktop
@@ -1,5 +1,5 @@
[contenttype_datauri_02.html]
type: testharness
[Data URI document.contentType === 'text/html' when data URI MIME type is set]
expected: FAIL
expected: TIMEOUT

2 ...pt/metadata/dom/nodes/Document-contentType/contentType/contenttype_javascripturi.html.ini
View file
Open in desktop
@@ -1,5 +1,5 @@
[contenttype_javascripturi.html]
type: testharness
[Javascript URI document.contentType === 'text/html']
expected: FAIL
expected: TIMEOUT

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Mar 30, 2017

Member

Are all these tests really timing out with your changes?

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Mar 30, 2017

Member

An easy way to check is to make a build on a branch that does not include any of the changes in this PR and run the tests again.

This comment has been minimized.

Sign in to view
Copy link
@krishnakarthick1993

krishnakarthick1993 Apr 1, 2017 •
edited

Those tests timed out without our changes. We ran the tests on a unmodified servo code.

106 tests/wpt/metadata/dom/nodes/Document-createElement.html.ini
View file
Open in desktop
@@ -1,161 +1,161 @@
[Document-createElement.html]
type: testharness
[createElement(undefined) in XML document]
expected: FAIL
expected: TIMEOUT

[createElement(null) in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f1oo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo1") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("fெ") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("fooெ") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement(":") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement(":foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f:oo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo:") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f:o:o") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f::oo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f::oo:") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo:0") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo:_") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo:ெ") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo:fooெ") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("fooெ:foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("xml") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("xmlns") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("xmlfoo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("xml:foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("xmlns:foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("xmlfoo:bar") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("svg") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("math") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("FOO") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("marK") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("İnput") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("ınput") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("1foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("1:foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("fo o") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("ெfoo") in HTML document]
expected: FAIL
expected: TIMEOUT

[createElement("ெfoo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("ெfoo") in XHTML document]
expected: FAIL
expected: TIMEOUT

[createElement("}foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f}oo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo}") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("\\ufffffoo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f\\uffffoo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo\\uffff") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("<foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("foo>") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("<foo>") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("f<oo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("-foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement(".foo") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("ெ") in HTML document]
expected: FAIL
expected: TIMEOUT

[createElement("ெ") in XML document]
expected: FAIL
expected: TIMEOUT

[createElement("ெ") in XHTML document]
expected: FAIL
expected: TIMEOUT

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.