Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Include content rules from HTMLTableCellElement::WalkContentStyleRules #16199

Merged
merged 1 commit into from Mar 31, 2017
Merged

stylo: Include content rules from HTMLTableCellElement::WalkContentStyleRules #16199

merged 1 commit into from Mar 31, 2017
+12 −0

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 31, 2017 •
edited by larsbergstrom

This also removes the TABLE_ATTRS_DIRTY optimization. Constructing nsMappedAttributes isn't really expensive and we do it all the time anyway.

r=bz https://bugzilla.mozilla.org/show_bug.cgi?id=1341648

This change is Reviewable
@Manishearth
stylo: Include content rules from HTMLTableCellElement::WalkContentSt…
Loading status checks…
bfc2cc4 
…yleRules

This also removes the TABLE_ATTRS_DIRTY optimization. Constructing nsMappedAttributes isn't really expensive and we do it all the time anyway.
@highfive
Copy link

highfive commented Mar 31, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/wrapper.rs, components/style/gecko_bindings/bindings.rs
  • @emilio: components/style/gecko/wrapper.rs, components/style/gecko_bindings/bindings.rs
@highfive
Copy link

highfive commented Mar 31, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member Author

Manishearth commented Mar 31, 2017

@bors-servo r=bz
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2017

📌 Commit bfc2cc4 has been approved by bz
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2017

⌛ Testing commit bfc2cc4 with merge 6519503...
bors-servo added a commit that referenced this pull request Mar 31, 2017
@bors-servo
Auto merge of #16199 - Manishearth:stylo-td-content, r=bz
Loading status checks…
6519503 
stylo: Include content rules from HTMLTableCellElement::WalkContentStyleRules

This also removes the TABLE_ATTRS_DIRTY optimization. Constructing nsMappedAttributes isn't really expensive and we do it all the time anyway.

r=bz https://bugzilla.mozilla.org/show_bug.cgi?id=1341648

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2017

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member Author

Manishearth commented Mar 31, 2017 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-css, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: bz
Pushing 6519503 to master...
@bors-servo bors-servo merged commit bfc2cc4 into servo:master Mar 31, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:stylo-td-content branch Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @bors-servo @metajack
You can’t perform that action at this time.