Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-mozjs to master. #16210

Merged
merged 1 commit into from Apr 1, 2017
Merged

Update rust-mozjs to master. #16210

merged 1 commit into from Apr 1, 2017

Conversation

@jdm
Copy link
Member

jdm commented Mar 31, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #16152
  • There are tests for these changes

This change is Reviewable
@jdm
Update rust-mozjs to master.
Loading status checks…
8cba0df
@highfive
Copy link

highfive commented Mar 31, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/script_runtime.rs
  • @KiChjang: components/script/script_runtime.rs
@highfive
Copy link

highfive commented Mar 31, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@wafflespeanut
Copy link
Member

wafflespeanut commented Apr 1, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2017

📌 Commit 8cba0df has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned metajack Apr 1, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2017

⌛ Testing commit 8cba0df with merge 2ebddca...
bors-servo added a commit that referenced this pull request Apr 1, 2017
@bors-servo
Auto merge of #16210 - jdm:updatejs, r=Wafflespeanut
Loading status checks…
2ebddca 
Update rust-mozjs to master.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16152
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16210)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: Wafflespeanut
Pushing 2ebddca to master...
@bors-servo bors-servo merged commit 8cba0df into servo:master Apr 1, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Call JS_ShutDown after closing last script thread
5 participants
@jdm @highfive @wafflespeanut @bors-servo @metajack
You can’t perform that action at this time.