test whitespace in pseudo-element selector throws syntax error

[jacksonweekes]

Issue #15448 - Land the test cases that should've landed with the selectors update. Tests that syntax error is thrown when pseudo-element selector contains whitespace - related to issue #15335

---

• [X ] ./mach build -d does not report any errors
• [X ] ./mach test-tidy does not report any errors
• These changes fix #15448 (github issue number if applicable).

• There are tests for these changes OR
• [X ] These changes do not require tests because implements a test not included when issue #15335 was fixed

---

This change is 

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

[emilio]

Hi, thanks for doing this!

Seems like you need to update the test manifest so CI is green (./mach update-manifest).

We should also add tests for empty attribute selectors. There are some tests already, but we need to check [attr$=""] and [attr=^=""].

Thanks again for looking into this!

[emilio]

nit: You have a tab in this line that should be converted to spaces.

[jacksonweekes]

Hi @emilio thanks for reviewing! I have fixed the whitespace issue but just wanted to clarify about the checks for empty attribute selectors. I have added
{name: "Invalid [att=value] selector", selector: "[attr$=\"\"]"}, {name: "Invalid [att=value] selector", selector: "[attr=^=\"\"]"},
to invalid selectors, however the first test fails. I'm not sure if I've misunderstood you or the parser is just not throwing an error for this case. Any advice?

[emilio]

Sorry, those are not invalid selectors.

[attr$=""] is a valid selector, we should make sure it matches nothing. [attr=^=""] is indeed an invalid selector, but that's just because I made a typo (it should be [attr^=""]).

[jdm]

@jacksonweekes Are you planning to finish this?

[bors-servo]

☔ The latest upstream changes (presumably #17822) made this pull request unmergeable. Please resolve the merge conflicts.

[emilio]

Closing due to lack of activity.