devtools: Implemented `console.group` and `console.groupEnd`

[HarryLovesCode]

• Modified WebIDL file to allow for Group, GroupCollapsed, GroupEnd functions
• Added log level Group, GroupCollapsed, and GroupEnd
• Added functionality for preparing and sending messages with groups

Notes

• Needs logging. This commit (currently) does not complete issue #9274
• Needs console.groupCollapsed implementation

Nightly Edition without Group Labels

Developer Edition without Group Labels

Nightly Edition with Group Labels

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #__ (github issue number if applicable).

• There are tests for these changes OR
• These changes do not require tests because there are no means to test the developer tools currently

---

This change is 

[highfive]

Heads up! This PR modifies the following files:

• @fitzgen: components/script/dom/webidls/Console.webidl, components/script/dom/console.rs, components/devtools/lib.rs, components/devtools_traits/lib.rs, components/devtools_traits/lib.rs
• @KiChjang: components/script/dom/webidls/Console.webidl, components/script/dom/console.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[jdm]

Why'd you revert the commit?

[HarryLovesCode]

@jdm GitKraken glitch sorry about that..

[jdm]

One change should avoid a bunch of the redundant DOMString::new() additions.

[jdm]

Given that only Group passes a real value for this, and it's a copy of the message, why not remove the extra argument and infer the groupName value based on the log level?

[HarryLovesCode]

Are you suggesting removing the argument from prepare_message and, since we are sending the label as the message, using that instead of the extra argument?

[jdm]

That is correct.

[jdm]

As for tests, we do not have any automated way of testing our devtools integration, unfortunately. I'm not sure what "needs logging" means.

[HarryLovesCode]

@jdm Side question, any reason Servo's WebIDL's are statically typed?

// Servo
void log(DOMString... messages);
void info(DOMString... messages);
// Firefox
void log(any... data);
void info(any... data);

[jdm]

Probably because that was the easiest way to get some kind of usable string value that we could print to the terminal. Firefox does more complicated formatting than toString(), so it makes sense to take an actual object.

Why doesn't this PR complete #9274? It looks like it's ready to merge if you squash the two commits into one.

[HarryLovesCode]

@jdm Isn't #9274 referring to logging to the command line?

[jdm]

Ooh, good point.

[bors-servo]

☔ The latest upstream changes (presumably #17355) made this pull request unmergeable. Please resolve the merge conflicts.

[jdm]

Closing due to inactivity.