Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic MutationObserver interface stubs #16268

Merged
merged 1 commit into from Apr 5, 2017
Merged

Basic MutationObserver interface stubs #16268

merged 1 commit into from Apr 5, 2017

Conversation

@jdm
Copy link
Member

jdm commented Apr 5, 2017 •
edited by larsbergstrom

Rebase and squash of #16190.

This change is Reviewable
@srivassumit @jdm
Implement basic interface for MutationObserver and MutationRecord.
Loading status checks…
107ac9a
@highfive
Copy link

highfive commented Apr 5, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/webidls/MutationObserver.webidl, components/script/dom/mod.rs, components/script/dom/mutationobserver.rs, components/script/script_thread.rs, components/script/dom/mutationrecord.rs, components/script/dom/webidls/MutationRecord.webidl
  • @KiChjang: components/script/dom/webidls/MutationObserver.webidl, components/script/dom/mod.rs, components/script/dom/mutationobserver.rs, components/script/script_thread.rs, components/script/dom/mutationrecord.rs, components/script/dom/webidls/MutationRecord.webidl
@highfive
Copy link

highfive commented Apr 5, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm jdm mentioned this pull request Apr 5, 2017
Closed
4 of 5 tasks complete
@jdm
Copy link
Member Author

jdm commented Apr 5, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2017

⌛ Trying commit 107ac9a with merge 89f46c4...
bors-servo added a commit that referenced this pull request Apr 5, 2017
@bors-servo
Auto merge of #16268 - jdm:tmp, r=<try>
Loading status checks…
89f46c4 
Basic MutationObserver interface stubs

Rebase and squash of #16190.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16268)
<!-- Reviewable:end -->
@jdm jdm assigned jdm and unassigned wafflespeanut Apr 5, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Apr 5, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2017

📌 Commit 107ac9a has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2017

⌛ Testing commit 107ac9a with merge 8e2a147...
bors-servo added a commit that referenced this pull request Apr 5, 2017
@bors-servo
Auto merge of #16268 - jdm:tmp, r=jdm
Loading status checks…
8e2a147 
Basic MutationObserver interface stubs

Rebase and squash of #16190.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16268)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 8e2a147 to master...
@bors-servo bors-servo merged commit 107ac9a into servo:master Apr 5, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Apr 5, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @wafflespeanut @srivassumit
You can’t perform that action at this time.