Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root nodes for the duration of their CSS transitions #16295

Merged
merged 5 commits into from May 15, 2017
Merged

Root nodes for the duration of their CSS transitions #16295

merged 5 commits into from May 15, 2017
+244 −90

Commits on May 15, 2017

  1. Root nodes for the duration of their CSS transitions. 

    This ensures that we can pass a node address as part of the asynchronous
transition end notification, making it safe to fire the corresponding
DOM event on the node from the script thread. Without explicitly rooting
this node when the transition starts, we risk the node being GCed before
the transition is complete.
    @jdm
    jdm committed May 15, 2017
    dabebdf

  2. Accumulate transitioning nodes inside the layout context.

    @jdm
    jdm committed May 15, 2017
    c3b9714

  3. Send information to script as part of finishing layout. 

    This avoids the need for multiple layout RPC operations immediately
following return of control to script. This means that layout and
script can continue to operate in parallel at this point, rather
than one potentially waiting on the shared mutex to be unlocked.
    @jdm
    jdm committed May 15, 2017
    9134918

  4. Warn about ignored transitions which can't be rooted.

    @jdm
    jdm committed May 15, 2017
    2ca80a8

  5. Make methods storing layout-originating nodes unsafe.

    @jdm
    jdm committed May 15, 2017
    Loading status checks…
    b0bf2b4
You can’t perform that action at this time.