Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root nodes for the duration of their CSS transitions #16295

Merged
merged 5 commits into from May 15, 2017

Warn about ignored transitions which can't be rooted.

  • Loading branch information
jdm committed May 15, 2017
commit 2ca80a800f8c1f85135bbdb605f69641ae9aa7d0
@@ -115,11 +115,15 @@ pub fn update_animation_state(constellation_chan: &IpcSender<ConstellationMsg>,

// Add new running animations.
for new_running_animation in new_running_animations {
match newly_transitioning_nodes {
Some(ref mut nodes) if new_running_animation.is_transition() => {
nodes.push(new_running_animation.node().to_untrusted_node_address());
if new_running_animation.is_transition() {
match newly_transitioning_nodes {
Some(ref mut nodes) => {
nodes.push(new_running_animation.node().to_untrusted_node_address());
}
None => {
warn!("New transition encountered from compositor-initiated layout.");
}
}
_ => ()
}

running_animations.entry(*new_running_animation.node())
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.