Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Make font base size computation threadsafe #16316

Merged
merged 3 commits into from Apr 9, 2017
Merged

stylo: Make font base size computation threadsafe #16316

merged 3 commits into from Apr 9, 2017

Conversation

@Manishearth
Copy link
Member

Manishearth commented Apr 9, 2017 •
edited by larsbergstrom

r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1351200

This change is Reviewable
@Manishearth
stylo: Bypass cache when fetching font size prefs from Stylo
2ea8d61
@highfive
Copy link

highfive commented Apr 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo/media_queries.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_bindings/structs_release.rs, components/style/values/computed/mod.rs, components/style/values/specified/length.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/matching.rs, components/style/gecko_string_cache/mod.rs, components/style/properties/longhand/font.mako.rs, components/style/viewport.rs, components/style/font_metrics.rs, components/style/stylist.rs, components/style/gecko_bindings/bindings.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/animation.rs, components/style/context.rs, components/style/build_gecko.rs
  • @KiChjang: components/script_layout_interface/wrapper_traits.rs, components/script/layout_wrapper.rs
  • @fitzgen: components/script_layout_interface/wrapper_traits.rs, components/script/layout_wrapper.rs
  • @emilio: components/style/servo/media_queries.rs, components/style/gecko_bindings/structs_debug.rs, ports/geckolib/glue.rs, components/style/gecko_bindings/structs_release.rs, components/style/values/computed/mod.rs, components/layout/animation.rs, components/style/values/specified/length.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/matching.rs, components/style/gecko_string_cache/mod.rs, components/style/properties/longhand/font.mako.rs, components/style/viewport.rs, components/style/font_metrics.rs, components/style/stylist.rs, components/style/gecko_bindings/bindings.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/animation.rs, components/style/context.rs, components/style/build_gecko.rs
@highfive
Copy link

highfive commented Apr 9, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style, layout, and script code, but no tests are modified. Please consider adding a test!
@Manishearth Manishearth force-pushed the Manishearth:stylo-threadsafe branch from 45f8fee to f51045e Apr 9, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Apr 9, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

📌 Commit f51045e has been approved by emilio
@highfive highfive assigned emilio and unassigned glennw Apr 9, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Apr 9, 2017

@bors-servo p=20
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

⌛ Testing commit f51045e with merge 8248d7b...
bors-servo added a commit that referenced this pull request Apr 9, 2017
@bors-servo
Auto merge of #16316 - Manishearth:stylo-threadsafe, r=emilio
Loading status checks…
8248d7b 
stylo: Make font base size computation threadsafe

r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1351200

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16316)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

💔 Test failed - android
Manishearth added 2 commits Apr 4, 2017
@Manishearth
stylo: Store font metrics provider in thread local style context
e402c72
@Manishearth
stylo: Use font metrics provider as a cache for font size results
Loading status checks…
2febe7c
@Manishearth Manishearth force-pushed the Manishearth:stylo-threadsafe branch from f51045e to 2febe7c Apr 9, 2017
@Manishearth
Copy link
Member Author

Manishearth commented Apr 9, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

📌 Commit 2febe7c has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

⌛ Testing commit 2febe7c with merge d77d752...
bors-servo added a commit that referenced this pull request Apr 9, 2017
@bors-servo
Auto merge of #16316 - Manishearth:stylo-threadsafe, r=emilio
Loading status checks…
d77d752 
stylo: Make font base size computation threadsafe

r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1351200

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16316)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

Manishearth commented Apr 9, 2017

@bors-servo r-

going for dinner, will try later.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member Author

Manishearth commented Apr 9, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

📌 Commit 2febe7c has been approved by emilio
@highfive highfive removed the S-tests-failed label Apr 9, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing d77d752 to master...
@bors-servo bors-servo merged commit 2febe7c into servo:master Apr 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 9, 2017
Merged
4 of 4 tasks complete
@Manishearth Manishearth deleted the Manishearth:stylo-threadsafe branch Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @bors-servo @emilio @glennw
You can’t perform that action at this time.