Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the version of cssparser to 0.12.2 #16343

Closed
wants to merge 1 commit into from
Closed

update the version of cssparser to 0.12.2 #16343

wants to merge 1 commit into from
+14 −14

Conversation

@kuoe0
Copy link
Contributor

kuoe0 commented Apr 11, 2017 •
edited by larsbergstrom

Update cssparser to 0.12.2. It supports new hsla() syntax defined in CSS Color Module Level 4.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because the test cases already in cssparser.

This change is Reviewable
@kuoe0
update the version of cssparser to 0.12.2
Loading status checks…
a164528
@highfive
Copy link

highfive commented Apr 11, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 11, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2017

⌛ Trying commit a164528 with merge b03ba1c...
bors-servo added a commit that referenced this pull request Apr 11, 2017
@bors-servo
Auto merge of #16343 - KuoE0:cssparser-0.12.2, r=<try>
Loading status checks…
b03ba1c 
update the version of cssparser to 0.12.2

<!-- Please describe your changes on the following line: -->

Update cssparser to 0.12.2. It supports new hsla() syntax defined in [CSS Color Module Level 4](https://drafts.csswg.org/css-color-4/#the-hsl-notation).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because the test cases already in cssparser.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16343)
<!-- Reviewable:end -->
@shinglyu
Copy link
Member

shinglyu commented Apr 11, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2017

📌 Commit a164528 has been approved by shinglyu
@highfive highfive assigned shinglyu and unassigned wafflespeanut Apr 11, 2017
@shinglyu
Copy link
Member

shinglyu commented Apr 11, 2017

@bors-servo r-
@shinglyu
Copy link
Member

shinglyu commented Apr 11, 2017

@kuoe0 said it will break the build, so r-
@SimonSapin
Copy link
Member

SimonSapin commented Apr 11, 2017

Yes, I expect that this will affect some test results, so I used try to see how exactly.
@kuoe0
Copy link
Contributor Author

kuoe0 commented Apr 11, 2017

@SimonSapin I think it will make stylo build failed.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 11, 2017

Gecko does not use servo/Cargo.lock, it has its own toolkit/library/rust/Cargo.lock.
@kuoe0
Copy link
Contributor Author

kuoe0 commented Apr 11, 2017

Oh, I see. Thanks!
@KiChjang
Copy link
Member

KiChjang commented Apr 11, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2017

⌛ Trying commit a164528 with merge a51ed03...
bors-servo added a commit that referenced this pull request Apr 11, 2017
@bors-servo
Auto merge of #16343 - KuoE0:cssparser-0.12.2, r=<try>
Loading status checks…
a51ed03 
update the version of cssparser to 0.12.2

<!-- Please describe your changes on the following line: -->

Update cssparser to 0.12.2. It supports new hsla() syntax defined in [CSS Color Module Level 4](https://drafts.csswg.org/css-color-4/#the-hsl-notation).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because the test cases already in cssparser.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16343)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2017

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Apr 11, 2017 

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-7

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-8

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-7

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-8

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-3.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-3
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-3.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-4.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-4
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-4.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-5.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-5
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-5.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ FAIL [expected PASS] /css-color-3_dev/html4/t424-hsl-parsing-f.htm
  └   → /css-color-3_dev/html4/t424-hsl-parsing-f.htm 761f7358bca6b67752e1d9873cda8fe43d5f9560
/css-color-3_dev/html4/reference/t424-hsl-parsing-f-ref.htm fe2c3476b94c89006012c065180248bc6522b435
Testing 761f7358bca6b67752e1d9873cda8fe43d5f9560 == fe2c3476b94c89006012c065180248bc6522b435

  ▶ FAIL [expected PASS] /css-color-3_dev/html4/t425-hsla-parsing-f.htm
  └   → /css-color-3_dev/html4/t425-hsla-parsing-f.htm 761f7358bca6b67752e1d9873cda8fe43d5f9560
/css-color-3_dev/html4/reference/t424-hsl-parsing-f-ref.htm fe2c3476b94c89006012c065180248bc6522b435
Testing 761f7358bca6b67752e1d9873cda8fe43d5f9560 == fe2c3476b94c89006012c065180248bc6522b435
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

☔ The latest upstream changes (presumably #16589) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 25, 2017

Oops, I forgot about this one when I submitted #16589 which basically does the same. Sorry!
@SimonSapin SimonSapin closed this Apr 25, 2017
@kuoe0
Copy link
Contributor Author

kuoe0 commented Apr 25, 2017

Ha, it's ok! I also focus on stylo, and not spend much time on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shinglyu shinglyu

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@kuoe0 @highfive @SimonSapin @bors-servo @shinglyu @KiChjang @jdm @wafflespeanut
You can’t perform that action at this time.