Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo - add glue code for initial-letter property #16349

Merged
merged 1 commit into from Apr 12, 2017

Conversation

@chenpighead
Copy link
Contributor

chenpighead commented Apr 11, 2017

Add glue code for initial-letter property.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

highfive commented Apr 11, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/properties/longhand/text.mako.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/properties/longhand/text.mako.rs
@highfive
Copy link

highfive commented Apr 11, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@chenpighead
Copy link
Contributor Author

chenpighead commented Apr 11, 2017

r? @heycam

@highfive highfive assigned heycam and unassigned KiChjang Apr 11, 2017
@heycam
Copy link
Member

heycam commented Apr 11, 2017

@bors-servo delegate+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2017

✌️ @chenpighead can now approve this pull request

@chenpighead
Copy link
Contributor Author

chenpighead commented Apr 12, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2017

📌 Commit 76b48c3 has been approved by heycam

@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2017

Testing commit 76b48c3 with merge 52c6873...

bors-servo added a commit that referenced this pull request Apr 12, 2017
…ycam

Stylo - add glue code for initial-letter property

<!-- Please describe your changes on the following line: -->

Add glue code for initial-letter property.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16349)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing 52c6873 to master...

@bors-servo bors-servo merged commit 76b48c3 into servo:master Apr 12, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.