Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (gradients, batching, text run, border changes). #16360

Merged
merged 1 commit into from Apr 12, 2017
Merged

Update WR (gradients, batching, text run, border changes). #16360

merged 1 commit into from Apr 12, 2017

Conversation

@glennw
Copy link
Member

glennw commented Apr 12, 2017 •
edited by larsbergstrom

  • Tidy and optimize the batching code.
  • Support tiling / repeat for linear and radial gradients.
  • Fix some edge cases of subpixel text AA.
  • Add clip mask support to border shaders.
  • Optimization to text run creation on CPU.
  • Handle more box-shadow clipping cases.
  • Fix a panic that could occur when window size is 0.
  • Clip / scroll API improvements.

This change is Reviewable
@gw3583
Update WR (gradients, batching, text run, border changes).
Loading status checks…
9e874f5 
- Tidy and optimize the batching code.
- Support tiling / repeat for linear and radial gradients.
- Fix some edge cases of subpixel text AA.
- Add clip mask support to border shaders.
- Optimization to text run creation on CPU.
- Handle more box-shadow clipping cases.
- Fix a panic that could occur when window size is 0.
- Clip / scroll API improvements.
@highfive
Copy link

highfive commented Apr 12, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/layout/webrender_helpers.rs, components/layout/display_list_builder.rs
@highfive
Copy link

highfive commented Apr 12, 2017

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Apr 12, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2017

📌 Commit 9e874f5 has been approved by jdm
@atouchet atouchet mentioned this pull request Apr 12, 2017
Closed
11 of 11 tasks complete
bors-servo added a commit that referenced this pull request Apr 12, 2017
@bors-servo
Auto merge of #16360 - glennw:update-wr-borders, r=jdm
Loading status checks…
43bd0ca 
Update WR (gradients, batching, text run, border changes).

- Tidy and optimize the batching code.
- Support tiling / repeat for linear and radial gradients.
- Fix some edge cases of subpixel text AA.
- Add clip mask support to border shaders.
- Optimization to text run creation on CPU.
- Handle more box-shadow clipping cases.
- Fix a panic that could occur when window size is 0.
- Clip / scroll API improvements.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16360)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2017

⌛ Testing commit 9e874f5 with merge 43bd0ca...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 43bd0ca to master...
@bors-servo bors-servo merged commit 9e874f5 into servo:master Apr 12, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 12, 2017
Merged
4 of 5 tasks complete
@glennw glennw deleted the glennw:update-wr-borders branch Apr 12, 2017
@atouchet atouchet mentioned this pull request Apr 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@glennw @highfive @jdm @bors-servo @gw3583
You can’t perform that action at this time.