Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1354970 - Add @counter-style rules #16455

Merged
merged 26 commits into from Apr 26, 2017
Merged

Bug 1354970 - Add @counter-style rules #16455

merged 26 commits into from Apr 26, 2017
+1,140 −134

Commits on Apr 26, 2017

  1. Introduce a style::values::CustomIdent type

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    4993a80

  2. Use CustomIdent for animation-name and @Keyframes

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    d9c2d1a

  3. Use CustomIdent in counter-increment

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    627c823

  4. Fix up unit tests

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    71f9a0c

  5. Remove some intermediate conversions in style/properties/gecko.mako.rs

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    5a8e330

  6. Add initial style system support for @counter-style rules

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    797f40b

  7. Add the 'system' descriptor of @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    4477a2d

  8. Add 'negative' descriptor of @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    d1558a2

  9. Add 'prefix' and 'suffix' descriptors for @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    29bcb5b

  10. Add 'range' descriptor to @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    6f79684

  11. Add 'pad' descritor of @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    e27de38

  12. Add 'fallback' descriptor to @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    0ba5cae

  13. Add the 'symbols' descriptor for @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    fe15663

  14. CSSOM requires @counter-style to keep track of which descriptors were… 

    … specified
    @SimonSapin
    SimonSapin committed Apr 26, 2017
    617e8e9

  15. Don’t make up initial values not in spec for @counter-style descriptors

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    f93a9a4

  16. Add 'additive-symbols' descriptor for @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    62d261a

  17. Add speak-as descriptor for @counter-style

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    6dc317f

  18. Check rule-level @counter-style validity

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    331acfa

  19. Add missing 'additive-symbols' validity checks

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    ade56bb

  20. Make the style::counter_style module a directory

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    e7a2a98

  21. Make predefined counter style names ASCII-lowercase.

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    82c0411

  22. Keep custom-ident and string separate in animation/keyframes name.

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    1146921

  23. Allow 'decimal' and 'none' in `<counter-style-name>` 

    … other than in `@counter-style`.
    @SimonSapin
    SimonSapin committed Apr 26, 2017
    0ff64bd

  24. Consider `foo` and `"foo"` equal as keyframes/animation names.

    @SimonSapin
    SimonSapin committed Apr 26, 2017
    be38c9a

  25. Exclude 'none' from <counter-style-name> after all. 

    w3c/csswg-drafts#1295
    @SimonSapin
    SimonSapin committed Apr 26, 2017
    Loading status checks…
    029150c

  26. CSSKeyframesRule::name setter doesn’t throw anymore 

    w3c/csswg-drafts@063dc05
web-platform-tests/wpt#5695
    @SimonSapin
    SimonSapin committed Apr 26, 2017
    Loading status checks…
    1b41900
You can’t perform that action at this time.