Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix various issues with overflow clipping #16463
Merged
Conversation
highfive
commented
Apr 14, 2017
|
Heads up! This PR modifies the following files:
|
| @@ -1953,6 +1953,12 @@ impl BlockFlowDisplayListBuilding for BlockFlow { | |||
| // we don't want it to be clipped by its own scroll root. | |||
| let containing_scroll_root_id = self.setup_scroll_root_for_block(state); | |||
|
|
|||
| match self.positioning() { | |||
| position::T::absolute | position::T::relative | position::T::fixed => | |||
This comment has been minimized.
This comment has been minimized.
emilio
Apr 16, 2017
Member
Perhaps a new method that returns a boolean if this matches could avoid some duplication?
This comment has been minimized.
This comment has been minimized.
mrobinson
force-pushed the
mrobinson:various-overflow-fixes
branch
from
cd07cbc
to
668078e
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2017
Fix various issues with overflow clipping When dealing absolutely positioned items, we should use clip of our containing block, even if our containing block doesn't itself establish a new overflow clip. Additionally, we need to properly handle assigning scroll root ids to fragments of inline elements. We add a test for this behavior. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16463) <!-- Reviewable:end -->
|
|
When dealing absolutely positioned items, we should use clip of our containing block, even if our containing block doesn't itself establish a new overflow clip. Additionally, we need to properly handle assigning scroll root ids to fragments of inline elements. We add a test for this behavior.
mrobinson
force-pushed the
mrobinson:various-overflow-fixes
branch
from
668078e
to
4213b32
|
The new test is failing, but one result is currently incorrect because of #16462. I'm going to try to disable this particular test case (until the bug is fixed), on the chance that the bug is causing platform-dependent behavior. The new branch should have updated version of the test. @emilio, is it okay that I try to land this again? |
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2017
Fix various issues with overflow clipping When dealing absolutely positioned items, we should use clip of our containing block, even if our containing block doesn't itself establish a new overflow clip. Additionally, we need to properly handle assigning scroll root ids to fragments of inline elements. We add a test for this behavior. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16463) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedApr 14, 2017
•
edited by larsbergstrom
When dealing absolutely positioned items, we should use clip of our
containing block, even if our containing block doesn't itself establish
a new overflow clip. Additionally, we need to properly handle
assigning scroll root ids to fragments of inline elements.
We add a test for this behavior.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is