Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove windows-gnu build code #16468
Merged
Conversation
|
r? @metajack |
These builds have been deprecated, so we don't need to keep this code around anymore.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 15, 2017
Remove windows-gnu build code <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16468) <!-- Reviewable:end -->
|
@metajack do you think it's OK to remove the other three mentions of |
|
Yes. we can always pull it back out of Git. |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2017
Remove windows gnu part 2 <!-- Please describe your changes on the following line: --> This is a follow-up to #16468. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because we no longer support MinGW/MSYS <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16490) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 15, 2017
•
edited by larsbergstrom
This is a follow-up to servo/saltfs#620.
There are three other places
windows-gnuis mentioned, I'm not sure if they can also be removed or not:nightly-x86_64-pc-windows-gnuis listed as a target in theappveyor.ymlbuild matrixhost_platforminpython/servo/util.pywindows_gnubootstrapper inpython/servo/bootstrap.py./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is