Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespaces of elements created in XML documents #16472

Merged
merged 1 commit into from Apr 20, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -2772,7 +2772,14 @@ impl DocumentMethods for Document {
if self.is_html_document {
local_name.make_ascii_lowercase();
}
let name = QualName::new(ns!(html), LocalName::from(local_name));

let ns = if self.is_html_document || self.content_type == "application/xhtml+xml" {
ns!(html)
} else {
ns!()
};

let name = QualName::new(ns, LocalName::from(local_name));
Ok(Element::create(name, None, self, ElementCreator::ScriptCreated))
}

@@ -0,0 +1,4 @@
[Document-constructor.html]
type: testharness
[new Document(): URL parsing]
expected: FAIL

This file was deleted.

"testharness"
],
"mozilla/document_head.html": [
"31892b141aba3b317502e38a4a38fcd8531cb8aa",
"b861fe5a1159ba5fba44d3aee048cdb27d378be9",
"testharness"
],
"mozilla/document_images_cache.html": [
@@ -13,8 +13,8 @@

test(function() {
var new_document = new Document();
new_document.appendChild(new_document.createElement("html"));
var new_head = new_document.createElement("head");
new_document.appendChild(new_document.createElementNS('http://www.w3.org/1999/xhtml', "html"));
var new_head = new_document.createElementNS('http://www.w3.org/1999/xhtml', 'head');

assert_not_equals(new_head, null, "test2-0, append head to a new document");
assert_true(new_head instanceof HTMLHeadElement, "test2-1, append head to a new document: should be HTMLHeadElement");
@@ -30,9 +30,9 @@

test(function() {
var new_document = new Document();
var html = new_document.createElement("html");
var foo = new_document.createElement("foo");
var head = new_document.createElement("head");
var html = new_document.createElementNS('http://www.w3.org/1999/xhtml', "html");
var foo = new_document.createElementNS('http://www.w3.org/1999/xhtml', "foo");
var head = new_document.createElementNS('http://www.w3.org/1999/xhtml', "head");
new_document.appendChild(html);
html.appendChild(foo);
foo.appendChild(head);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.