Upgrade to rustc 1.18.0-nightly (5f13a3b54 2017-04-15) #16473

Merged
merged 1 commit into from Apr 16, 2017

Conversation

Projects
None yet
4 participants
@SimonSapin
Member

SimonSapin commented Apr 15, 2017

This version enables struct field reordering which brings the size of the types for specified values of some CSS properties under the threshold such that they shouldn’t be boxed anymore, making unit tests fail.

Simply unboxing them moves the test failure to Stylo’s unit tests, since the stable compiler used in that case does not do field re-ordering. Therefore, we manually reorder a couple fields to effectively bring this optimization to older compilers for a few specific types.


This change is Reviewable

Upgrade to rustc 1.18.0-nightly (5f13a3b54 2017-04-15)
This version enables [struct field reordering][1] which brings the size
of the types for specified values of some CSS properties under the threshold
such that they shouldn’t be boxed anymore, making unit tests fail.

Simply unboxing them moves the test failure to Stylo’s unit tests,
since the stable compiler used in that case does not do field re-ordering.
Therefore, we manually reorder a couple fields to effectively bring this
optimization to older compilers for a few specific types.

[1]: rust-lang/rust#40377
@emilio

This comment has been minimized.

Show comment
Hide comment
Member

emilio commented Apr 16, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Apr 16, 2017

Contributor

📌 Commit daba024 has been approved by emilio

Contributor

bors-servo commented Apr 16, 2017

📌 Commit daba024 has been approved by emilio

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Apr 16, 2017

Contributor

⌛️ Testing commit daba024 with merge c453e2e...

Contributor

bors-servo commented Apr 16, 2017

⌛️ Testing commit daba024 with merge c453e2e...

bors-servo added a commit that referenced this pull request Apr 16, 2017

Auto merge of #16473 - servo:rustup, r=emilio
Upgrade to rustc 1.18.0-nightly (5f13a3b54 2017-04-15)

This version enables [struct field reordering][1] which brings the size of the types for specified values of some CSS properties under the threshold such that they shouldn’t be boxed anymore, making unit tests fail.

Simply unboxing them moves the test failure to Stylo’s unit tests, since the stable compiler used in that case does not do field re-ordering. Therefore, we manually reorder a couple fields to effectively bring this optimization to older compilers for a few specific types.

[1]: rust-lang/rust#40377

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16473)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Apr 16, 2017

Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing c453e2e to master...

Contributor

bors-servo commented Apr 16, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing c453e2e to master...

@bors-servo bors-servo merged commit daba024 into master Apr 16, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Apr 16, 2017

Merged

stylo: Implement -moz-transform property #16231

3 of 3 tasks complete

@saneyuki saneyuki deleted the rustup branch Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment