Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAutomatically clean old nightlies #16487
Conversation
highfive
commented
Apr 16, 2017
|
Heads up! This PR modifies the following files:
|
aneeshusa
force-pushed the
aneeshusa:automatically-clean-old-nightlies
branch
from
feab3dd
to
4ea88d4
|
|
This makes it easier to reuse in other places.
Add a new `-keep` flag to `./mach clean-nightlies` to control how many nightlies to keep, which keeps the n most recent nightlies found in git. Use this to clean old nightlies at the start of each build, currently keeping 3 nightlies at a time.
aneeshusa
force-pushed the
aneeshusa:automatically-clean-old-nightlies
branch
from
4ea88d4
to
060a813
|
I'm not sure that we want to delete all of the nightlies. Firefox has gotten a lot of mileage out of being able to do a "binary bisection" to find when bugs were introduced without having to rebuild the product. That said, it might only be useful for the tarballs and not for the installers themselves. |
|
@larsbergstrom Sorry that I wasn't clear, this deletes |
|
@aneeshusa Whoops! I should have read the change instead of just the PR comment. I've done so now and thanks a ton for this! @bors-servo r+ |
|
|
…=larsbergstrom Automatically clean old nightlies <!-- Please describe your changes on the following line: --> Automatically clean old rustc and cargo nightlies on our builders up to preserve disk space. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #12103 and help with servo/saltfs#321 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because tested manually <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16487) <!-- Reviewable:end -->
|
|
aneeshusa commentedApr 16, 2017
•
edited
Automatically clean old rustc and cargo nightlies on our builders up to preserve disk space.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is