Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically clean old nightlies #16487

Merged
merged 2 commits into from Apr 18, 2017

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Apr 16, 2017

Automatically clean old rustc and cargo nightlies on our builders up to preserve disk space.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12103 and help with servo/saltfs#321 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because tested manually

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Apr 16, 2017

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/util.py, python/servo/bootstrap_commands.py, python/servo/package_commands.py
@aneeshusa

This comment has been minimized.

Copy link
Member Author

aneeshusa commented Apr 16, 2017

@aneeshusa aneeshusa force-pushed the aneeshusa:automatically-clean-old-nightlies branch from feab3dd to 4ea88d4 Apr 18, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Apr 18, 2017

☔️ The latest upstream changes (presumably #16505) made this pull request unmergeable. Please resolve the merge conflicts.

aneeshusa added 2 commits Apr 16, 2017
This makes it easier to reuse in other places.
Add a new `-keep` flag to `./mach clean-nightlies` to control how many
nightlies to keep, which keeps the n most recent nightlies found in git.

Use this to clean old nightlies at the start of each build,
currently keeping 3 nightlies at a time.
@aneeshusa aneeshusa force-pushed the aneeshusa:automatically-clean-old-nightlies branch from 4ea88d4 to 060a813 Apr 18, 2017
@larsbergstrom

This comment has been minimized.

Copy link
Contributor

larsbergstrom commented Apr 18, 2017

I'm not sure that we want to delete all of the nightlies. Firefox has gotten a lot of mileage out of being able to do a "binary bisection" to find when bugs were introduced without having to rebuild the product.

That said, it might only be useful for the tarballs and not for the installers themselves.

Thoughts, @metajack & @jdm?

@aneeshusa

This comment has been minimized.

Copy link
Member Author

aneeshusa commented Apr 18, 2017

@larsbergstrom Sorry that I wasn't clear, this deletes rustc and cargo nightlies, not Servo nightlies! The old compilers take up quite a bit of space, I think ~20GB on the Windows builders.

@larsbergstrom

This comment has been minimized.

Copy link
Contributor

larsbergstrom commented Apr 18, 2017

@aneeshusa Whoops! I should have read the change instead of just the PR comment. I've done so now and thanks a ton for this!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Apr 18, 2017

📌 Commit 060a813 has been approved by larsbergstrom

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Apr 18, 2017

⌛️ Testing commit 060a813 with merge a754c10...

bors-servo added a commit that referenced this pull request Apr 18, 2017
…=larsbergstrom

Automatically clean old nightlies

<!-- Please describe your changes on the following line: -->

Automatically clean old rustc and cargo nightlies on our builders up to preserve disk space.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12103 and help with servo/saltfs#321 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because tested manually

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16487)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Apr 18, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: larsbergstrom
Pushing a754c10 to master...

@bors-servo bors-servo merged commit 060a813 into servo:master Apr 18, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.