Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows gnu part 2 #16490

Merged
merged 2 commits into from Apr 17, 2017

Conversation

@aneeshusa
Copy link
Member

commented Apr 17, 2017

This is a follow-up to #16468.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because we no longer support MinGW/MSYS

This change is Reviewable

aneeshusa added 2 commits Apr 15, 2017
Originally introduced in PR #11646,
this appears to have been accidentally broken by commit
82df8e9.
@highfive

This comment has been minimized.

Copy link

commented Apr 17, 2017

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/bootstrap.py, python/servo/command_base.py, python/servo/package_commands.py, python/servo/packages.py, python/mach_bootstrap.py and 3 more
@aneeshusa

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2017

@highfive highfive assigned metajack and unassigned emilio Apr 17, 2017
@metajack

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2017

squash and r=me, unless you think it makes sense to keep that commit separate

@aneeshusa

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2017

The macOS commit is unrelated to the Windows changes but I just noticed it while working on this, so I'll keep it as a separate commit. @bors-servo r=metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2017

📌 Commit 022f0aa has been approved by metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2017

⌛️ Testing commit 022f0aa with merge 485a4de...

bors-servo added a commit that referenced this pull request Apr 17, 2017
Remove windows gnu part 2

<!-- Please describe your changes on the following line: -->

This is a follow-up to #16468.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because we no longer support MinGW/MSYS

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16490)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: metajack
Pushing 485a4de to master...

@bors-servo bors-servo merged commit 022f0aa into servo:master Apr 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo referenced this pull request Apr 17, 2017
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.