Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert unnecessary changes to canvas image drawing tests. #16492
Conversation
|
r? @KiChjang |
|
Would this cause issues with other browsers? |
|
No. This is reverting changes I made to the tests that were never upstreamed. |
|
@bors-servo r+ |
|
|
|
|
|
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 21, 2017
Revert unnecessary changes to canvas image drawing tests. These changes were made as part of #14962 under the assumption that images not in the document do not delay the load event. That assumption is incorrect. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16492) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 17, 2017
•
edited by larsbergstrom
These changes were made as part of #14962 under the assumption that images not in the document do not delay the load event. That assumption is incorrect.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is