Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop mach bootstrap from segfaulting #16505

Merged

Commits on Apr 18, 2017

  1. Stop segfaulting at the end of mach bootstrap

    `mach bootstrap` will finish succesfully,
    but then segfault inside glibc while exiting.
    It seems to have to do with the MarkupSafe library used by Mako;
    delaying the Mako import from the top level to inside functions where it
    is used avoids the problem.
    (It seems to interact with the call to pip to install the Salt
    requirements in the virtualenv, as commenting that pip call out
    separately will also fix the segfault.)
    
    Also, use the Mako installed in the Python virtualenv while running
    packaging commands (instead of the one from the bundled zip file),
    and cleanup imports in the package_commands.py file.
    aneeshusa committed Apr 18, 2017
You can’t perform that action at this time.