Make non-initial about:blank loads async #16506

cbrewster · 2017-04-18T01:36:20Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #14856 (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2017-04-18T01:36:24Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/constellation.rs, components/constellation/frame.rs
@fitzgen: components/script/dom/htmliframeelement.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script_traits/lib.rs and 1 more
@KiChjang: components/script/dom/htmliframeelement.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script_traits/lib.rs and 1 more

highfive · 2017-04-18T01:36:25Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

cbrewster · 2017-04-18T01:37:12Z

@bors-servo try

bors-servo · 2017-04-18T01:37:17Z

⌛ Trying commit 2e4e583 with merge 9e66cfd...


        Auto merge of #16506 - cbrewster:about_chaos, r=<try>

Make non-initial about:blank loads async  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14856 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16506)

bors-servo · 2017-04-18T01:59:12Z

💔 Test failed - linux-rel-css

cbrewster · 2017-04-18T02:21:22Z

A few reftests use iframes with src set as data:text/html,.... Should these be loaded synchronously or async? If async, these tests need to be updated to wait until the load event is fired at the iframe.

Edit: I was not checking pending_pipeline_id when receiving the message to update the active iframe pipeline. This caused the LoadBlocker to terminate too soon which allowed the window's load event to fire before the iframe finished loading.

cbrewster · 2017-04-18T02:46:54Z

@bors-servo try

bors-servo · 2017-04-18T02:46:58Z

⌛ Trying commit 143b2ed with merge b9cb01e...


        Auto merge of #16506 - cbrewster:about_chaos, r=<try>

Make non-initial about:blank loads async  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14856 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16506)

bors-servo · 2017-04-18T03:08:01Z

💔 Test failed - linux-rel-css

cbrewster · 2017-04-18T04:40:52Z

@bors-servo try

bors-servo · 2017-04-18T04:40:56Z

⌛ Trying commit 9f67d14 with merge b718514...


        Auto merge of #16506 - cbrewster:about_chaos, r=<try>

Make non-initial about:blank loads async  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14856 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16506)

bors-servo · 2017-04-18T05:02:12Z

💔 Test failed - mac-rel-wpt1

cbrewster · 2017-04-18T05:05:01Z

Getting much closer!

Tests with unexpected results:
  ▶ CRASH [expected OK] /html/semantics/embedded-content/image-maps/image-map-processing-model/hash-name-reference.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  │ called `Option::unwrap()` on a `None` value (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(1) }, at src/libcore/option.rs:329)
  │ 2017-04-18 00:54:31.532 servo[58029:933566178] Metadata.framework [Error]: couldn't get the client port
  │ stack backtrace:
  │    0:        0x110dbc84e - backtrace::backtrace::trace::hbf2fa9001442e91d
  │    1:        0x110dbd0fc - backtrace::capture::Backtrace::new::hb8a21c7c3bfbd0d6
  │    2:        0x10f6f1868 - servo::main::_$u7b$$u7b$closure$u7d$$u7d$::h247fa11c17e4b9ac
  │    3:        0x111280dc9 - std::panicking::rust_panic_with_hook::h4573918fc9f80a34
  │    4:        0x111280c74 - std::panicking::begin_panic::hea1fbdbb50f104e1
  │    5:        0x111280b92 - std::panicking::begin_panic_fmt::hc84782a62933404a
  │    6:        0x111280af7 - rust_begin_unwind
  │    7:        0x1112a8cf0 - core::panicking::panic_fmt::hef95123b2596925e
  │    8:        0x1112a8bf4 - core::panicking::panic::hd9c540bdbb8c1e4f
  │    9:        0x10fc2be51 - _$LT$script..dom..document..Document$u20$as$u20$script..dom..bindings..codegen..Bindings..DocumentBinding..DocumentBinding..DocumentMethods$GT$::ElementFromPoint::hafdddfdaec3267ec
  │   10:        0x10f93b078 - std::panicking::try::do_call::h11faafce930728d0
  │   11:        0x111281e2a - __rust_maybe_catch_panic
  │   12:        0x10fec295c - script::dom::bindings::codegen::Bindings::DocumentBinding::DocumentBinding::elementFromPoint::h219e3ce62fad1b6b
  │   13:        0x1100d8898 - CallJitMethodOp
  │   14:        0x10fbafbe4 - script::dom::bindings::utils::generic_call::h6d1ed89f6d2db7c7
  │   15:        0x110543f7e - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   16:        0x110544435 - js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)
  │   17:        0x1104e918e - js::Wrapper::call(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) const
  │   18:        0x1104dad1b - js::CrossCompartmentWrapper::call(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) const
  │   19:        0x1104e0a29 - js::Proxy::call(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&)
  │   20:        0x1104e13b9 - js::proxy_Call(JSContext*, unsigned int, JS::Value*)
  │   21:        0x1105441aa - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   22:        0x11053d79c - Interpret(JSContext*, js::RunState&)
  │   23:        0x110530e5a - js::RunScript(JSContext*, js::RunState&)
  │   24:        0x1105442d2 - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   25:        0x110544435 - js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)
  │   26:        0x11046f7f0 - js::fun_apply(JSContext*, unsigned int, JS::Value*)
  │   27:        0x110543f7e - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   28:        0x11053d79c - Interpret(JSContext*, js::RunState&)
  │   29:        0x110530e5a - js::RunScript(JSContext*, js::RunState&)
  │   30:        0x1105442d2 - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   31:        0x11053d79c - Interpret(JSContext*, js::RunState&)
  │   32:        0x110530e5a - js::RunScript(JSContext*, js::RunState&)
  │   33:        0x1105442d2 - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   34:        0x11053d79c - Interpret(JSContext*, js::RunState&)
  │   35:        0x110530e5a - js::RunScript(JSContext*, js::RunState&)
  │   36:        0x1105442d2 - js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)
  │   37:        0x110544435 - js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)
  │   38:        0x11040f749 - JS_CallFunctionValue(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>)
  │   39:        0x10feeabdb - script::dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull::Call::h48d497413cb33169
  │   40:        0x10fc557d1 - script::dom::eventtarget::CompiledEventListener::call_or_handle_event::hb2ffe652865673c6
  │   41:        0x10fc500f5 - script::dom::event::invoke::h5b3efb45210aa95b
  │   42:        0x10fc4f507 - script::dom::event::Event::dispatch::h3578933d3d26b266
  │   43:        0x10fc2e7cc - _$LT$script..dom..document..DocumentProgressHandler$u20$as$u20$script..script_thread..Runnable$GT$::handler::h160c09a022b91eb0
  │   44:        0x10fdaba32 - _$LT$script..script_thread..CancellableRunnable$LT$T$GT$$u20$as$u20$script..script_thread..Runnable$GT$::main_thread_handler::hd9caa846d7f5eb43
  │   45:        0x10fde5223 - script::task_source::dom_manipulation::DOMManipulationTask::handle_task::h8eb30bbe991c214a
  │   46:        0x10fdc2fc9 - script::script_thread::ScriptThread::handle_msg_from_script::hda54b04e4dbe44bc
  │   47:        0x10fdbe4ca - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::h2fbf4e257191ec77
  │   48:        0x10fdbaf87 - script::script_thread::ScriptThread::handle_msgs::h7d3522fa5e70cd5b
  │   49:        0x10f928557 - std::panicking::try::do_call::h058b732c4aff78f1
  │   50:        0x111281e2a - __rust_maybe_catch_panic
  │   51:        0x10fae8ad6 - _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::he7928813516e8a57
  │   52:        0x11127d944 - std::sys::imp::thread::Thread::new::thread_start::hba7593f2e1f1beb1
  │   53:     0x7fff8afbb059 - _pthread_body
  │   54:     0x7fff8afbafd6 - _pthread_start
  │ ERROR:servo: called `Option::unwrap()` on a `None` value
  └ Pipeline failed in hard-fail mode.  Crashing!

  ▶ Unexpected subtest result in /html/semantics/forms/form-submission-0/form-data-set-usv.html:
  │ FAIL [expected PASS] Submitting a form data set that contains unpaired surrogates must convert to Unicode scalar values
  │   → assert_equals: expected "69 6e 70 75 74 31 ef bf bd 3d 69 6e 70 75 74 31 ef bf bd 0d 0a 69 6e 70 75 74 32 ef bf bd 3d 69 6e 70 75 74 32 ef bf bd 0d 0a 69 6e 70 75 74 33 ef bf bd 3d 69 6e 70 75 74 33 ef bf bd 0d 0a 69 6e 70 75 74 34 ef bf bd 3d 69 6e 70 75 74 34 ef bf bd 0d 0a" but got "\n  \n  \n    option\n  \n  \n  \n\n\n\n\"use strict\";\n\nconst form = document.querySelector(\"form\");\n\nfor (let el of Array.from(form.querySelectorAll(\"input\"))) { // Firefox/Edge support\n  el.name = el.id + \"\\uDC01\";\n  el.value = el.id + \"\uDC01\";\n}\n\nconst select = document.querySelector(\"select\");\nselect.name = select.id + \"\uDC01\";\nselect.firstElementChild.value = select.id + \"\uDC01\";\n\n"
  │ 
  │ window.onload</iframe.onload<@http://web-platform.test:8000/html/semantics/forms/form-submission-0/form-data-set-usv.html:23:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  └ Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1449:17

  ▶ OK [expected TIMEOUT] /html/semantics/scripting-1/the-script-element/module/crossorigin.html

  ▶ Unexpected subtest result in /html/semantics/scripting-1/the-script-element/module/crossorigin.html:
  │ FAIL [expected NOTRUN] Root module, Error in CORS-different-origin script
  │   → assert_equals: Unexpected _log value expected "running,0-0" but got ""
  │ FAIL [expected NOTRUN] Root module, Error in CORS-same-origin script
  │   → assert_equals: Unexpected _log value expected "running,8-1" but got ""
  │ FAIL [expected NOTRUN] Root module, Blocked script download, missing CORS ACAO header
  │   → assert_equals: Unexpected _log value expected "error" but got ""
  │ FAIL [expected NOTRUN] Root module, Blocked script download, mismatched CORS ACAO header
  │   → assert_equals: Unexpected _log value expected "error" but got ""
  │ FAIL [expected NOTRUN] Imported module, Error in CORS-different-origin script
  │   → assert_equals: Unexpected _log value expected "running,0-0" but got ""
  │ FAIL [expected NOTRUN] Imported module, Error in CORS-same-origin script
  │   → assert_equals: Unexpected _log value expected "running,8-1" but got ""
  │ FAIL [expected NOTRUN] Imported module, Blocked script download, missing CORS ACAO header
  │   → assert_equals: Unexpected _log value expected "error" but got ""
  │ FAIL [expected NOTRUN] Imported module, Blocked script download, mismatched CORS ACAO header
  │   → assert_equals: Unexpected _log value expected "error" but got ""
  │ 
  │ @http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/module/crossorigin.html:35:21
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  │ @http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/module/crossorigin.html:34:17
  └ @http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/module/crossorigin.html:32:13

  ▶ OK [expected TIMEOUT] /html/semantics/scripting-1/the-script-element/script-onerror-insertion-point-2.html

  ▶ Unexpected subtest result in /fetch/api/request/multi-globals/url-parsing.html:
  │ FAIL [expected PASS] should parse the URL relative to the current settings object
  └   → promise_test: Unhandled rejection with value: object "TypeError: Url could not be parsed"

  ▶ Unexpected subtest result in /fetch/api/response/multi-globals/url-parsing.html:
  │ FAIL [expected PASS] should parse the redirect Location URL relative to the current settings object
  └   → promise_test: Unhandled rejection with value: object "TypeError: ServoUrl could not be parsed"

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function.html:
  │ FAIL [expected PASS] Set location from a function called from a parent
  │   → assert_equals: expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/source/support/location-set.html" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function.html"
  │ 
  │ onload</fr.onload<@http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function.html:15:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  └ Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1449:17

  ▶ CRASH [expected OK] /html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  └ Pipeline failed in hard-fail mode.  Crashing!

  ▶ OK [expected ERROR] /html/dom/dynamic-markup-insertion/opening-the-input-stream/009.html

  ▶ Unexpected subtest result in /html/dom/dynamic-markup-insertion/opening-the-input-stream/009.html:
  │ FAIL [expected PASS] document.open replacing singleton
  │   → steps is undefined
  │ 
  └ onload@http://web-platform.test:8000/html/dom/dynamic-markup-insertion/opening-the-input-stream/009.html:32:3

cbrewster · 2017-04-21T04:02:58Z

@bors-servo try


        Auto merge of #16506 - cbrewster:about_chaos, r=<try>

Make non-initial about:blank loads async  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14856 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16506)

cbrewster · 2017-05-12T17:54:48Z

@bors-servo r=asajeffrey

bors-servo · 2017-05-12T17:54:56Z

📌 Commit f0220ab has been approved by asajeffrey

bors-servo · 2017-05-12T18:43:04Z

⌛ Testing commit f0220ab with merge 2ff09b7...


        Auto merge of #16506 - cbrewster:about_chaos, r=asajeffrey

Make non-initial about:blank loads async  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14856 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16506)

bors-servo · 2017-05-12T19:01:00Z

💔 Test failed - linux-dev

jdm · 2017-05-12T19:34:13Z


Running the WPT lint on ./tests/wpt/web-platform-tests/...
{"path": "html/semantics/embedded-content/the-iframe-element/content_document_changes_only_after_load_matures.html", "message": "Console logging API used", "lineno": 12, "rule": "CONSOLE"}

WPT Lint Tool:: lint error(s) in Web Platform Tests: exit status 1


        Add test to make sure contentDocument is updated after load matures

cbrewster · 2017-05-12T19:55:26Z

@bors-servo r=asajeffrey

bors-servo · 2017-05-12T19:55:26Z

📌 Commit 727e5b4 has been approved by asajeffrey

bors-servo · 2017-05-12T20:08:47Z

⌛ Testing commit 727e5b4 with merge dc8cf69...


        Auto merge of #16506 - cbrewster:about_chaos, r=asajeffrey

Make non-initial about:blank loads async  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14856 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16506)

bors-servo · 2017-05-12T22:03:41Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: asajeffrey
Pushing dc8cf69 to master...


        Add test to make sure contentDocument is updated after load matures

Upstreamed from servo/servo#16506 [ci skip]

highfive assigned mbrubeck Apr 18, 2017

highfive added the S-awaiting-review label Apr 18, 2017

cbrewster mentioned this pull request Apr 18, 2017

[WIP] Make subsequent about:blank loads async #14764

Closed

3 of 5 tasks complete

highfive added the S-tests-failed label Apr 18, 2017

cbrewster force-pushed the cbrewster:about_chaos branch from 2e4e583 to 143b2ed Apr 18, 2017

highfive removed the S-tests-failed label Apr 18, 2017

highfive added the S-tests-failed label Apr 18, 2017

cbrewster mentioned this pull request Apr 18, 2017

Combine FramedContentChanged into UpdatePipelineId #16503

Closed

4 of 5 tasks complete

cbrewster force-pushed the cbrewster:about_chaos branch from 143b2ed to 9f67d14 Apr 18, 2017

highfive removed the S-tests-failed label Apr 18, 2017

highfive added the S-tests-failed label Apr 18, 2017

mbrubeck removed their assignment Apr 18, 2017

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-squash labels May 12, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels May 12, 2017

Add test to make sure contentDocument is updated after load matures

Loading status checks…

727e5b4

cbrewster force-pushed the cbrewster:about_chaos branch from f0220ab to 727e5b4 May 12, 2017

highfive added S-awaiting-review and removed S-tests-failed labels May 12, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels May 12, 2017

bors-servo merged commit 727e5b4 into servo:master May 12, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 12, 2017

This was referenced May 12, 2017

Remove logic from webrender_helpers.rs #16838

Closed

Redirect document loads manually #15354

Merged

cbrewster mentioned this pull request May 12, 2017

Combine UpdatePipelineId and FramedContentChanged #14854

Closed

cbrewster deleted the cbrewster:about_chaos branch May 12, 2017

jdm added a commit to web-platform-tests/wpt that referenced this pull request Jun 19, 2017

Add test to make sure contentDocument is updated after load matures

9dd9478

Upstreamed from servo/servo#16506 [ci skip]

jdm mentioned this pull request Jun 19, 2017

Add test to make sure contentDocument is updated after load matures web-platform-tests/wpt#6278

Merged

servo / servo

Make non-initial about:blank loads async #16506

Make non-initial about:blank loads async #16506

cbrewster commented Apr 18, 2017 •

edited by larsbergstrom

highfive commented Apr 18, 2017

highfive commented Apr 18, 2017

cbrewster commented Apr 18, 2017

bors-servo commented Apr 18, 2017

bors-servo commented Apr 18, 2017

cbrewster commented Apr 18, 2017 •

edited

cbrewster commented Apr 18, 2017

bors-servo commented Apr 18, 2017

bors-servo commented Apr 18, 2017

cbrewster commented Apr 18, 2017

bors-servo commented Apr 18, 2017

bors-servo commented Apr 18, 2017

cbrewster commented Apr 18, 2017

cbrewster commented Apr 21, 2017

cbrewster commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

jdm commented May 12, 2017

cbrewster commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

servo / servo

Join GitHub today

Make non-initial about:blank loads async #16506

Make non-initial about:blank loads async #16506

Conversation

cbrewster commented Apr 18, 2017 • edited by larsbergstrom

highfive commented Apr 18, 2017

highfive commented Apr 18, 2017

cbrewster commented Apr 18, 2017

bors-servo commented Apr 18, 2017

bors-servo commented Apr 18, 2017

cbrewster commented Apr 18, 2017 • edited

cbrewster commented Apr 18, 2017

bors-servo commented Apr 18, 2017

bors-servo commented Apr 18, 2017

cbrewster commented Apr 18, 2017

bors-servo commented Apr 18, 2017

bors-servo commented Apr 18, 2017

cbrewster commented Apr 18, 2017

cbrewster commented Apr 21, 2017

cbrewster commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

jdm commented May 12, 2017

cbrewster commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

bors-servo commented May 12, 2017

cbrewster commented Apr 18, 2017 •

edited by larsbergstrom

cbrewster commented Apr 18, 2017 •

edited