Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse NativeFontHandle instead of CGFont #16512
Merged
+3
−2
Conversation
highfive
commented
Apr 18, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
highfive
commented
Apr 18, 2017
|
|
|
LGTM, once servo/webrender#1133 has landed. |
|
The dependencies have merged, so this can go in now! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 2, 2017
Use NativeFontHandle instead of CGFont <!-- Please describe your changes on the following line: --> ```serde``` is removed from ```core-graphics```, ```NativeFontHandle``` implements serialization and we should use ```NativeFontHandle``` instead of ```CGFont```. This PR depends on followings. servo/core-graphics-rs#82 servo/webrender#1133 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15607 (github issue number if applicable). <!-- Either: --> - [X] These changes do not require tests according to issue comment. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16512) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alfredoyang commentedApr 18, 2017
•
edited
serdeis removed fromcore-graphics,NativeFontHandleimplements serialization and we should useNativeFontHandleinstead ofCGFont.This PR depends on followings.
servo/core-graphics-rs#82
servo/webrender#1133
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is