Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate proper root ClipId when scrolling from script #16529
Merged
Conversation
|
Just need to fix up the manifest, then r=me. |
tests/wpt/mozilla/meta/MANIFEST.json
Outdated
| @@ -9717,6 +9729,11 @@ | |||
| {} | |||
| ] | |||
| ], | |||
| "mozilla/referrer-policy/generic/subresource/mozresource.pyc": [ | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mrobinson
Apr 19, 2017
Author
Member
Ugh. I should probably fix this script to ignore pyc files. Should be fixed now!
tests/wpt/mozilla/meta/MANIFEST.json
Outdated
| @@ -26005,6 +26027,10 @@ | |||
| "d5e7151e650a785f23df411f1f302116372f4dc6", | |||
| "support" | |||
| ], | |||
| "mozilla/referrer-policy/generic/subresource/mozresource.pyc": [ | |||
This comment has been minimized.
This comment has been minimized.
WebRender currently makes a distinction between an external ClipId with id equal to 0 and the root scroll ClipId. We need to detect this situation and properly form the ClipId for the root.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 19, 2017
Create proper root ClipId when scrolling from script WebRender currently makes a distinction between an external ClipId with id equal to 0 and the root scroll ClipId. We need to detect this situation and properly form the ClipId for the root. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16529) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedApr 19, 2017
•
edited by larsbergstrom
WebRender currently makes a distinction between an external ClipId with
id equal to 0 and the root scroll ClipId. We need to detect this
situation and properly form the ClipId for the root.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is