Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (improved double border quality, minor API changes). #16551

Merged
merged 3 commits into from Apr 23, 2017
Merged

Update WR (improved double border quality, minor API changes). #16551

merged 3 commits into from Apr 23, 2017

Conversation

@glennw
Copy link
Member

glennw commented Apr 21, 2017 •
edited by larsbergstrom

This change is Reviewable
@gw3583
Update WR (improved double border quality, minor API changes).
Loading status checks…
c4b1033
@highfive
Copy link

highfive commented Apr 21, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/layout/webrender_helpers.rs
@highfive
Copy link

highfive commented Apr 21, 2017

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@glennw
Copy link
Member Author

glennw commented Apr 21, 2017

r? anyone
@jdm
Copy link
Member

jdm commented Apr 21, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2017

📌 Commit c4b1033 has been approved by jdm
@highfive highfive assigned jdm and unassigned metajack Apr 21, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2017

⌛ Testing commit c4b1033 with merge 1c99558...
bors-servo added a commit that referenced this pull request Apr 21, 2017
@bors-servo
Auto merge of #16551 - glennw:update-wr-mostly-borders, r=jdm
Loading status checks…
1c99558 
Update WR (improved double border quality, minor API changes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2017

💔 Test failed - mac-dev-unit
@jdm
Copy link
Member

jdm commented Apr 21, 2017 

error[E0308]: mismatched types
   --> /Users/servo/buildbot/slave/mac-dev-unit/build/components/gfx/font_cache_thread.rs:352:90
    |
352 |                     (None, Some(native_font)) => webrender_api.add_native_font(font_key, native_font),
    |                                                                                          ^^^^^^^^^^^ expected struct `webrender_traits::NativeFontHandle`, found struct `core_graphics::font::CGFont`
    |
    = note: expected type `webrender_traits::NativeFontHandle`
               found type `core_graphics::font::CGFont`

error: aborting due to previous error

Want to pull #16512 into this as well?
alfredoyang @gw3583
Use NativeFontHandle instead of CGFont
Loading status checks…
13dd197
@glennw
Copy link
Member Author

glennw commented Apr 21, 2017

@jdm OK, I've added that commit.
@jdm
Copy link
Member

jdm commented Apr 21, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2017

📌 Commit 13dd197 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2017

⌛ Testing commit 13dd197 with merge c6dc3be...
bors-servo added a commit that referenced this pull request Apr 21, 2017
@bors-servo
Auto merge of #16551 - glennw:update-wr-mostly-borders, r=jdm
Loading status checks…
c6dc3be 
Update WR (improved double border quality, minor API changes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2017

💔 Test failed - mac-rel-css
@jdm
Copy link
Member

jdm commented Apr 21, 2017 

  ▶ PASS [expected FAIL] /css-transforms-1_dev/html/transform-input-018.htm
@gw3583
Update test expectations.
Loading status checks…
b60d1d0
@glennw
Copy link
Member Author

glennw commented Apr 23, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

⌛ Trying commit b60d1d0 with merge fc4e8a4...
bors-servo added a commit that referenced this pull request Apr 23, 2017
@bors-servo
Auto merge of #16551 - glennw:update-wr-mostly-borders, r=<try>
Loading status checks…
fc4e8a4 
Update WR (improved double border quality, minor API changes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
State: approved= try=True
@glennw
Copy link
Member Author

glennw commented Apr 23, 2017

@bors-servo r=jdm

  • Added a new pass as reported above.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

📌 Commit b60d1d0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

⌛ Testing commit b60d1d0 with merge 0f6c883...
bors-servo added a commit that referenced this pull request Apr 23, 2017
@bors-servo
Auto merge of #16551 - glennw:update-wr-mostly-borders, r=jdm
Loading status checks…
0f6c883 
Update WR (improved double border quality, minor API changes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 0f6c883 to master...
@bors-servo bors-servo merged commit b60d1d0 into servo:master Apr 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @highfive @jdm @bors-servo @metajack @gw3583
You can’t perform that action at this time.