Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #15725: Skip git ignored files in ./mach update-manifest #16562

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -85,6 +85,10 @@ def update(self, tree):
else:
new_type, manifest_items = old_type, self._data[old_type][rel_path]
else:
# Issue #15725: Skip git ignored files
from vcs import Git
if Git.is_ignored(source_file.tests_root, source_file.rel_path):
continue
new_type, manifest_items = source_file.manifest_items()

if new_type in ("reftest", "reftest_node"):
@@ -25,6 +25,15 @@ def for_path(cls, path, url_base):
except subprocess.CalledProcessError:
return None

@staticmethod
def is_ignored(dir_base, rel_path):
git = Git.get_func(dir_base)
try:
git("check-ignore", "-q", rel_path)
return True
except subprocess.CalledProcessError:
return False

def _local_changes(self):
changes = {}
cmd = ["status", "-z", "--ignore-submodules=all"]
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.