Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto clean old nightlies on Travis #16573

Merged
merged 2 commits into from Apr 23, 2017
Merged

Auto clean old nightlies on Travis #16573

merged 2 commits into from Apr 23, 2017

Conversation

@UK992
Copy link
Contributor

UK992 commented Apr 22, 2017

This could solve no space left problem.


This change is Reviewable

@UK992
Copy link
Contributor Author

UK992 commented Apr 22, 2017

@highfive highfive assigned aneeshusa and unassigned cbrewster Apr 22, 2017
Copy link
Member

aneeshusa left a comment

This is a good idea, thanks @UK992! I'm not sure if it will help with running out of space or not, but it doesn't hurt.

.travis.yml Outdated
@@ -11,6 +11,7 @@ matrix:
- sudo: 9000
dist: trusty
script:
- ./mach clean-nightlies --keep 2 --force

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Apr 22, 2017

Member

Let's put this into before_cache instead of script. Docs: https://docs.travis-ci.com/user/caching/#before_cache-phase

commit_hash, _ = cmd.communicate()
to_keep[tool].add(commit_hash.rstrip())
for line in stdout.splitlines():
if line.startswith("+") and "+++" not in line:

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Apr 22, 2017

Member

"+++" not in line -> not line.startswith("+++")

@@ -306,19 +306,14 @@ def clean_nightlies(self, force=False, keep=None):
for tool in ["rust", "cargo"]:
commit_file = '{}-commit-hash'.format(tool)
cmd = subprocess.Popen(
['git', 'log', '--pretty=format:%H', '-n', keep, commit_file],
['git', 'log', '--pretty=oneline', '--no-color', '-n', keep, '-p', commit_file],

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Apr 22, 2017

Member

Use --oneline instead of --pretty=oneline, and change -p to --patch.

@UK992 UK992 force-pushed the UK992:travis branch from 3ee9a22 to c5f1306 Apr 22, 2017
@UK992
Copy link
Contributor Author

UK992 commented Apr 22, 2017

done.

@aneeshusa
Copy link
Member

aneeshusa commented Apr 22, 2017

Looks good, I'll wait for Travis to see how it affects the output.

@aneeshusa
Copy link
Member

aneeshusa commented Apr 22, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2017

📌 Commit c5f1306 has been approved by aneeshusa

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

Testing commit c5f1306 with merge cc74b5b...

bors-servo added a commit that referenced this pull request Apr 23, 2017
Auto clean old nightlies on Travis

This could solve `no space left` problem.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16573)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

💔 Test failed - mac-rel-wpt1

@jdm
Copy link
Member

jdm commented Apr 23, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: aneeshusa
Pushing cc74b5b to master...

@bors-servo bors-servo merged commit c5f1306 into servo:master Apr 23, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request May 9, 2017
Try to re-enable unit tests on travis-ci

After #16573 and #16593, issue #15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16767)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 9, 2017
…UK992:travis); r=jdm

After servo/servo#16573 and servo/servo#16593, issue servo/servo#15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

Source-Repo: https://github.com/servo/servo
Source-Revision: 8ff484d3fd0b092d64af8b0a2cfa51b318631b82

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b2ee28ecf18792f3a1ebf50bcb548ede41fb2e70
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request May 10, 2017
…UK992:travis); r=jdm

After servo/servo#16573 and servo/servo#16593, issue servo/servo#15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

Source-Repo: https://github.com/servo/servo
Source-Revision: 8ff484d3fd0b092d64af8b0a2cfa51b318631b82
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…UK992:travis); r=jdm

After servo/servo#16573 and servo/servo#16593, issue servo/servo#15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

Source-Repo: https://github.com/servo/servo
Source-Revision: 8ff484d3fd0b092d64af8b0a2cfa51b318631b82

UltraBlame original commit: 2445c1a53fe2bf66317fcbb495a528eb68fdabc3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…UK992:travis); r=jdm

After servo/servo#16573 and servo/servo#16593, issue servo/servo#15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

Source-Repo: https://github.com/servo/servo
Source-Revision: 8ff484d3fd0b092d64af8b0a2cfa51b318631b82

UltraBlame original commit: 2445c1a53fe2bf66317fcbb495a528eb68fdabc3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…UK992:travis); r=jdm

After servo/servo#16573 and servo/servo#16593, issue servo/servo#15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

Source-Repo: https://github.com/servo/servo
Source-Revision: 8ff484d3fd0b092d64af8b0a2cfa51b318631b82

UltraBlame original commit: 2445c1a53fe2bf66317fcbb495a528eb68fdabc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.