Stylo: add -moz-border-*-colors support #16586

chenpighead · 2017-04-24T07:49:37Z

In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors.
We can simplify the implementation of computed value in Servo by using Option.
As to passing computed values from Servo to Gecko, we might need to use some
binding functions (pre-added in the same Gecko bug, see Bug 1348173).

Note that we also added -moz-border--colors as sub_properties of the 'border'
shorthand, so we can make the 'border' shorthand reset -moz-border--colors
(See Gecko Bug 482692).

A bit refactoring of replacing all ["top", "right", "bottom", "left"] with PHYSICAL_SIDES
is included in this patch, since we've already had PHYSICAL_SIDES for a while.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2017-04-24T07:49:41Z

Heads up! This PR modifies the following files:

@bholley: components/style/properties/gecko.mako.rs, components/style/build_gecko.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/longhand/border.mako.rs
@emilio: components/style/properties/gecko.mako.rs, components/style/build_gecko.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/longhand/border.mako.rs

highfive · 2017-04-24T07:49:42Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style code, but no tests are modified. Please consider adding a test!

chenpighead · 2017-04-24T07:50:42Z

r? @heycam
stylo try is still in progress...

heycam · 2017-04-24T07:52:28Z

@bors-servo delegate+

bors-servo · 2017-04-24T07:52:29Z

✌️ @chenpighead can now approve this pull request

chenpighead · 2017-04-24T08:03:50Z

@bors-servo try

bors-servo · 2017-04-24T08:03:54Z

⌛ Trying commit dd9fdee with merge 92b28b9...


        Auto merge of #16586 - chenpighead:stylo-moz-border-colors-support, r…

…=<try> Stylo: add -moz-border-*-colors support In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. We can simplify the implementation of computed value in Servo by using Option<Vec>. As to passing computed values from Servo to Gecko, we might need to use some binding functions (pre-added in the same Gecko bug, see Bug 1348173). Note that we also added -moz-border-*-colors as sub_properties of the 'border' shorthand, so we can make the 'border' shorthand reset -moz-border-*-colors (See Gecko Bug 482692). A bit refactoring of replacing all ["top", "right", "bottom", "left"] with PHYSICAL_SIDES is included in this patch, since we've already had PHYSICAL_SIDES for a while.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16586)

bors-servo · 2017-04-24T08:15:29Z

💔 Test failed - linux-dev

chenpighead · 2017-04-24T08:23:34Z

@bors-servo retry

bors-servo · 2017-04-24T08:23:38Z

⌛ Trying commit dd9fdee with merge e3d9434f340b3244da7f645eb881694ca9a44ce4...

bors-servo · 2017-04-24T08:34:51Z

💔 Test failed - windows-msvc-dev

chenpighead · 2017-04-24T08:46:12Z

@bors-servo try

bors-servo · 2017-04-24T08:46:17Z

⌛ Trying commit 43a15c0 with merge abc8857...


        Auto merge of #16586 - chenpighead:stylo-moz-border-colors-support, r…

…=<try> Stylo: add -moz-border-*-colors support In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. We can simplify the implementation of computed value in Servo by using Option<Vec>. As to passing computed values from Servo to Gecko, we might need to use some binding functions (pre-added in the same Gecko bug, see Bug 1348173). Note that we also added -moz-border-*-colors as sub_properties of the 'border' shorthand, so we can make the 'border' shorthand reset -moz-border-*-colors (See Gecko Bug 482692). A bit refactoring of replacing all ["top", "right", "bottom", "left"] with PHYSICAL_SIDES is included in this patch, since we've already had PHYSICAL_SIDES for a while.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16586)

bors-servo · 2017-04-24T08:57:21Z

💔 Test failed - windows-msvc-dev

chenpighead · 2017-04-24T09:13:20Z

Needs a bindings.rs update. I'll grab them as an artifact from the try push... still wait for a green stylo try.

bors-servo · 2017-04-25T01:04:27Z

📌 Commit d84ca07 has been approved by heycam

bors-servo · 2017-04-25T01:04:31Z

⌛ Testing commit d84ca07 with merge f309225...


        Auto merge of #16586 - chenpighead:stylo-moz-border-colors-support, r…

…=heycam Stylo: add -moz-border-*-colors support In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. We can simplify the implementation of computed value in Servo by using Option<Vec>. As to passing computed values from Servo to Gecko, we might need to use some binding functions (pre-added in the same Gecko bug, see Bug 1348173). Note that we also added -moz-border-*-colors as sub_properties of the 'border' shorthand, so we can make the 'border' shorthand reset -moz-border-*-colors (See Gecko Bug 482692). A bit refactoring of replacing all ["top", "right", "bottom", "left"] with PHYSICAL_SIDES is included in this patch, since we've already had PHYSICAL_SIDES for a while.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16586)

bors-servo · 2017-04-25T01:12:05Z

💔 Test failed - windows-msvc-dev


        Stylo: update bindings for -moz-border-*-colors support


        Stylo: add -moz-border-*-colors support

In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. We can simplify the implementation of computed value in Servo by using Option<Vec>. As to passing computed values from Servo to Gecko, we might need to use some binding functions (pre-added in the same Gecko bug, see Bug 1348173). Note that we added -moz-border-*-colors as sub_properties of the 'border' shorthand, so we can make the 'border' shorthand reset -moz-border-*-colors (See Gecko Bug 482692). However, since they are Gecko only non-standard properties, we should skip these sub_properties while doing unit testing in Servo. The test part should be convered by Stylo/Gecko already. A bit refactoring of replacing all ["top", "right", "bottom", "left"] with PHYSICAL_SIDES is included in this patch, since we've already had PHYSICAL_SIDES for a while.

chenpighead · 2017-04-25T02:03:49Z

@bors-servo r=heycam

bors-servo · 2017-04-25T02:03:49Z

📌 Commit 13f6cf6 has been approved by heycam

bors-servo · 2017-04-25T02:03:54Z

⌛ Testing commit 13f6cf6 with merge ef5c61e...


        Auto merge of #16586 - chenpighead:stylo-moz-border-colors-support, r…

…=heycam Stylo: add -moz-border-*-colors support In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. We can simplify the implementation of computed value in Servo by using Option<Vec>. As to passing computed values from Servo to Gecko, we might need to use some binding functions (pre-added in the same Gecko bug, see Bug 1348173). Note that we also added -moz-border-*-colors as sub_properties of the 'border' shorthand, so we can make the 'border' shorthand reset -moz-border-*-colors (See Gecko Bug 482692). A bit refactoring of replacing all ["top", "right", "bottom", "left"] with PHYSICAL_SIDES is included in this patch, since we've already had PHYSICAL_SIDES for a while.  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16586)

bors-servo · 2017-04-25T02:29:39Z

💔 Test failed - linux-rel-wpt

chenpighead · 2017-04-25T02:38:36Z

@bors-servo retry

bors-servo · 2017-04-25T02:38:38Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css, mac-rel-wpt2...

bors-servo · 2017-04-25T03:03:08Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing ef5c61e to master...


        Bug 1348173 - stylo: combined gecko side patch for -moz-border-*-colo…

…rs support. r=heycam 1. add binding functions for -moz-border-*-colors support. In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. The computed values of -moz-border-*-colors are set by couple member functions. To pass the computed value from Servo to Gecko, we need support for these member functions as well. So, I'm adding some binding functions in this patch. The actual use of these bindings to pass/store the computed values is separated in the following patch, which should be a pure Servo change. See servo PR: servo/servo#16586. 2. update test expectations for -moz-border-*-colors support. Note that with the support of -moz-border-*-colors, 165 mochitests and 17 reftests could be fixed. MozReview-Commit-ID: KDbp8C6Aoqd --HG-- extra : rebase_source : 7d9675d9ece091ea6957dcae7d28c39066e69035


        Bug 1348173 - stylo: combined gecko side patch for -moz-border-*-colo…

…rs support. r=heycam 1. add binding functions for -moz-border-*-colors support. In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. The computed values of -moz-border-*-colors are set by couple member functions. To pass the computed value from Servo to Gecko, we need support for these member functions as well. So, I'm adding some binding functions in this patch. The actual use of these bindings to pass/store the computed values is separated in the following patch, which should be a pure Servo change. See servo PR: servo/servo#16586. 2. update test expectations for -moz-border-*-colors support. Note that with the support of -moz-border-*-colors, 165 mochitests and 17 reftests could be fixed. MozReview-Commit-ID: KDbp8C6Aoqd UltraBlame original commit: 9c7c061b959fd3d6dc8f468aedaac0736ca7480c


        Bug 1348173 - stylo: combined gecko side patch for -moz-border-*-colo…

…rs support. r=heycam 1. add binding functions for -moz-border-*-colors support. In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. The computed values of -moz-border-*-colors are set by couple member functions. To pass the computed value from Servo to Gecko, we need support for these member functions as well. So, I'm adding some binding functions in this patch. The actual use of these bindings to pass/store the computed values is separated in the following patch, which should be a pure Servo change. See servo PR: servo/servo#16586. 2. update test expectations for -moz-border-*-colors support. Note that with the support of -moz-border-*-colors, 165 mochitests and 17 reftests could be fixed. MozReview-Commit-ID: KDbp8C6Aoqd UltraBlame original commit: 9c7c061b959fd3d6dc8f468aedaac0736ca7480c


        Bug 1348173 - stylo: combined gecko side patch for -moz-border-*-colo…

…rs support. r=heycam 1. add binding functions for -moz-border-*-colors support. In Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors. The computed values of -moz-border-*-colors are set by couple member functions. To pass the computed value from Servo to Gecko, we need support for these member functions as well. So, I'm adding some binding functions in this patch. The actual use of these bindings to pass/store the computed values is separated in the following patch, which should be a pure Servo change. See servo PR: servo/servo#16586. 2. update test expectations for -moz-border-*-colors support. Note that with the support of -moz-border-*-colors, 165 mochitests and 17 reftests could be fixed. MozReview-Commit-ID: KDbp8C6Aoqd UltraBlame original commit: 9c7c061b959fd3d6dc8f468aedaac0736ca7480c

highfive assigned emilio Apr 24, 2017

highfive added the S-awaiting-review label Apr 24, 2017

highfive assigned heycam and unassigned emilio Apr 24, 2017

bors-servo mentioned this pull request Apr 24, 2017

Introduce intermediate rgba #16587

Merged

3 of 3 tasks complete

highfive added the S-tests-failed label Apr 24, 2017

chenpighead force-pushed the chenpighead:stylo-moz-border-colors-support branch from dd9fdee to 43a15c0 Apr 24, 2017

highfive removed the S-tests-failed label Apr 24, 2017

highfive added the S-tests-failed label Apr 24, 2017

chenpighead force-pushed the chenpighead:stylo-moz-border-colors-support branch from 43a15c0 to 98d949e Apr 24, 2017

highfive removed the S-tests-failed label Apr 24, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 25, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 25, 2017

chenpighead added 2 commits Apr 24, 2017

Stylo: update bindings for -moz-border-*-colors support

3f3f780

chenpighead force-pushed the chenpighead:stylo-moz-border-colors-support branch from d84ca07 to 13f6cf6 Apr 25, 2017

highfive added S-awaiting-review and removed S-tests-failed labels Apr 25, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 25, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 25, 2017

bors-servo merged commit 13f6cf6 into servo:master Apr 25, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

servo / servo

Stylo: add -moz-border-*-colors support #16586

Stylo: add -moz-border-*-colors support #16586

chenpighead commented Apr 24, 2017 •

edited by larsbergstrom

highfive commented Apr 24, 2017

highfive commented Apr 24, 2017

chenpighead commented Apr 24, 2017

heycam commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

chenpighead commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

chenpighead commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

servo / servo

Join GitHub today

Stylo: add -moz-border-*-colors support #16586

Stylo: add -moz-border-*-colors support #16586

Conversation

chenpighead commented Apr 24, 2017 • edited by larsbergstrom

highfive commented Apr 24, 2017

highfive commented Apr 24, 2017

chenpighead commented Apr 24, 2017

heycam commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

chenpighead commented Apr 24, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

chenpighead commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

chenpighead commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

chenpighead commented Apr 24, 2017 •

edited by larsbergstrom