Fix fixed table layout column width distribution #16588

KiChjang · 2017-04-24T10:35:14Z

Replaces the incorrect CSS3 "distributing excess width to columns" algorithm and implements the simpler CSS2 fixed table layout algorithm.

This change is

highfive · 2017-04-24T10:35:18Z

Heads up! This PR modifies the following files:

@emilio: components/layout/table.rs

highfive · 2017-04-24T10:35:19Z

Warning

These commits modify layout code, but no tests are modified. Please consider adding a test!

KiChjang · 2017-04-24T10:35:24Z

@bors-servo try

bors-servo · 2017-04-24T10:35:29Z

⌛ Trying commit 9e39a80 with merge 97623ce...


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=<try> Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)

emilio · 2017-04-24T10:35:56Z

@bors-servo try

r? @mbrubeck

KiChjang · 2017-04-24T11:40:16Z

@bors-servo clean retry

bors-servo · 2017-04-24T11:40:20Z

⌛ Trying commit 9e39a80 with merge fe256ad...


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=<try> Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)

bors-servo · 2017-04-24T12:10:39Z

💔 Test failed - linux-rel-wpt

jdm · 2017-04-24T13:05:31Z

  ▶ FAIL [expected PASS] /css21_dev/html4/floats-149.htm
  ▶ FAIL [expected PASS] /_mozilla/css/fixed_percent.html
  ▶ FAIL [expected PASS] /_mozilla/css/border_spacing_fixed_layout_a.html

KiChjang · 2017-04-25T05:22:19Z

@bors-servo try

bors-servo · 2017-04-25T05:22:22Z

⌛ Trying commit 47ee799 with merge d673aef...


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=<try> Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)

bors-servo · 2017-04-25T05:35:31Z

💔 Test failed - linux-rel-css

KiChjang · 2017-04-25T05:36:59Z

Tests with unexpected results:
  ▶ FAIL [expected PASS] /css21_dev/html4/background-attachment-applies-to-001.htm
  └   → /css21_dev/html4/background-attachment-applies-to-001.htm b3a9a6440147e1eb6ddb79f95cb5f68277f98e6e
/css21_dev/html4/reference/background-attachment-applies-to-001-ref.htm da47ac50f6c835e9b6d4f2cbda6cc22a92e01f16
Testing b3a9a6440147e1eb6ddb79f95cb5f68277f98e6e == da47ac50f6c835e9b6d4f2cbda6cc22a92e01f16

  ▶ FAIL [expected PASS] /css21_dev/html4/background-attachment-applies-to-003.htm
  └   → /css21_dev/html4/background-attachment-applies-to-003.htm b3a9a6440147e1eb6ddb79f95cb5f68277f98e6e
/css21_dev/html4/reference/background-attachment-applies-to-001-ref.htm da47ac50f6c835e9b6d4f2cbda6cc22a92e01f16
Testing b3a9a6440147e1eb6ddb79f95cb5f68277f98e6e == da47ac50f6c835e9b6d4f2cbda6cc22a92e01f16

  ▶ FAIL [expected PASS] /css21_dev/html4/background-attachment-applies-to-002.htm
  └   → /css21_dev/html4/background-attachment-applies-to-002.htm b3a9a6440147e1eb6ddb79f95cb5f68277f98e6e
/css21_dev/html4/reference/background-attachment-applies-to-001-ref.htm da47ac50f6c835e9b6d4f2cbda6cc22a92e01f16
Testing b3a9a6440147e1eb6ddb79f95cb5f68277f98e6e == da47ac50f6c835e9b6d4f2cbda6cc22a92e01f16

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-001a.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-001.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-005.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-002.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-003.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-006.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-004.htm

  ▶ PASS [expected FAIL] /css21_dev/html4/float-applies-to-004a.htm

Iiiiiiiiiiinteresting results, going to investigate soon.

KiChjang · 2017-04-25T06:29:22Z

For all the test failures above, the flow tree indicates that the TableRowGroupFlow has a zero width. Tentatively guessing that something is wrong during assigning inline sizes.

KiChjang · 2017-04-26T00:36:27Z

@bors-servo try

bors-servo · 2017-04-26T00:36:31Z

⌛ Trying commit bd47c4e with merge 05fe6cc...


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=<try> Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=<try> Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)

jdm · 2017-04-28T14:32:26Z

@bors-servo: retry

bors-servo · 2017-04-28T14:32:29Z

⌛ Trying commit 2d5833d with merge 4b5d587...


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=<try> Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)

bors-servo · 2017-04-28T14:59:40Z

💔 Test failed - linux-rel-wpt

jdm · 2017-04-28T15:24:40Z

{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, basic", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247476, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, inline-block", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247477, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, img in span", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247478, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, the don't-wrap rule is only for the purpose of calculating the width of the cell", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247479, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, the quirk shouldn't apply for <input>", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247482, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, non-auto width on cell", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247486, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, display:table-cell on span", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247488, "message": null, "expected": "FAIL"}
{"status": "PASS", "stack": null, "subtest": "The table cell width calculation quirk, display:table-cell on span, wbr", "action": "test_result", "test": "/quirks-mode/table-cell-width-calculation.html", "line": 247489, "message": null, "expected": "FAIL"}

mbrubeck · 2017-04-28T17:15:29Z

Nice! r=mbrubeck with test expectations updated.

jdm · 2017-04-28T17:30:40Z

The tests expectations shouldn't be updated; it's an intermittent pass that #16640 hit as well.

jdm · 2017-04-28T17:31:56Z

@bors-servo: r=mbrubeck

bors-servo · 2017-04-28T17:31:57Z

📌 Commit 2d5833d has been approved by mbrubeck

bors-servo · 2017-04-28T17:56:08Z

⌛ Testing commit 2d5833d with merge bf32a7b...


        Auto merge of #16588 - KiChjang:fix-fixed-table-layout-column-width, …

…r=mbrubeck Fix fixed table layout column width distribution Fixes #16324. Replaces the incorrect [CSS3 "distributing excess width to columns" algorithm](https://drafts.csswg.org/css-tables-3/#distributing-width-to-columns) and implements the simpler [CSS2 fixed table layout algorithm](https://drafts.csswg.org/css2/tables.html#fixed-table-layout).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16588)

bors-servo · 2017-04-28T18:24:38Z

💔 Test failed - linux-rel-wpt

jdm · 2017-04-28T18:27:58Z

@bors-servo: retry

#16651

bors-servo · 2017-04-28T18:28:02Z

⚡ Previous build results for arm32, linux-dev, mac-dev-unit, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only android, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css, mac-rel-wpt2...

bors-servo · 2017-04-28T18:34:38Z

💔 Test failed - linux-rel-css

jdm · 2017-04-28T18:52:54Z

@bors-servo: retry

#16161

bors-servo · 2017-04-28T18:52:56Z

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-wpt2...

bors-servo · 2017-04-28T19:30:57Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: mbrubeck
Pushing bf32a7b to master...

highfive assigned asajeffrey Apr 24, 2017

highfive added the S-awaiting-review label Apr 24, 2017

highfive assigned mbrubeck and unassigned asajeffrey Apr 24, 2017

highfive added the S-tests-failed label Apr 24, 2017

KiChjang force-pushed the KiChjang:fix-fixed-table-layout-column-width branch from 9e39a80 to 47ee799 Apr 25, 2017

highfive removed the S-tests-failed label Apr 25, 2017

highfive added the S-tests-failed label Apr 25, 2017

KiChjang force-pushed the KiChjang:fix-fixed-table-layout-column-width branch from 47ee799 to bd47c4e Apr 26, 2017

highfive removed the S-tests-failed label Apr 26, 2017

highfive added the S-tests-failed label Apr 28, 2017

mbrubeck approved these changes Apr 28, 2017

View changes

mbrubeck removed the S-awaiting-review label Apr 28, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 28, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 28, 2017

highfive added the S-tests-failed label Apr 28, 2017

bors-servo merged commit 2d5833d into servo:master Apr 28, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

KiChjang deleted the KiChjang:fix-fixed-table-layout-column-width branch Apr 28, 2017

KiChjang mentioned this pull request Nov 21, 2017

bad render layout #19311

Open

servo / servo

Fix fixed table layout column width distribution #16588

Fix fixed table layout column width distribution #16588

KiChjang commented Apr 24, 2017 •

edited by larsbergstrom

highfive commented Apr 24, 2017

highfive commented Apr 24, 2017

KiChjang commented Apr 24, 2017

bors-servo commented Apr 24, 2017

emilio commented Apr 24, 2017

KiChjang commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

jdm commented Apr 24, 2017

KiChjang commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

KiChjang commented Apr 25, 2017

KiChjang commented Apr 25, 2017

KiChjang commented Apr 26, 2017

bors-servo commented Apr 26, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

jdm commented Apr 28, 2017

mbrubeck commented Apr 28, 2017

jdm commented Apr 28, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

servo / servo

Join GitHub today

Fix fixed table layout column width distribution #16588

Fix fixed table layout column width distribution #16588

Conversation

KiChjang commented Apr 24, 2017 • edited by larsbergstrom

highfive commented Apr 24, 2017

highfive commented Apr 24, 2017

KiChjang commented Apr 24, 2017

bors-servo commented Apr 24, 2017

emilio commented Apr 24, 2017

KiChjang commented Apr 24, 2017

bors-servo commented Apr 24, 2017

bors-servo commented Apr 24, 2017

jdm commented Apr 24, 2017

KiChjang commented Apr 25, 2017

bors-servo commented Apr 25, 2017

bors-servo commented Apr 25, 2017

KiChjang commented Apr 25, 2017

KiChjang commented Apr 25, 2017

KiChjang commented Apr 26, 2017

bors-servo commented Apr 26, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

jdm commented Apr 28, 2017

mbrubeck commented Apr 28, 2017

jdm commented Apr 28, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

jdm commented Apr 28, 2017

bors-servo commented Apr 28, 2017

bors-servo commented Apr 28, 2017

KiChjang commented Apr 24, 2017 •

edited by larsbergstrom