Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added origin to globalscope #16592

Merged
merged 1 commit into from Apr 24, 2017
Merged

added origin to globalscope #16592

merged 1 commit into from Apr 24, 2017

Conversation

@avadacatavra
Copy link
Contributor

avadacatavra commented Apr 24, 2017 •
edited by larsbergstrom

Replaces #16561

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@avadacatavra
added origin to globalscope
Loading status checks…
2c6bd51
@highfive
Copy link

highfive commented Apr 24, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/globalscope.rs, components/script/dom/workerglobalscope.rs, components/script/dom/dissimilaroriginlocation.rs, components/script/dom/dissimilaroriginwindow.rs, components/script/script_thread.rs and 4 more
  • @KiChjang: components/script/dom/globalscope.rs, components/script/dom/workerglobalscope.rs, components/script/dom/dissimilaroriginlocation.rs, components/script/dom/dissimilaroriginwindow.rs, components/script/script_thread.rs and 4 more
@highfive
Copy link

highfive commented Apr 24, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@avadacatavra avadacatavra mentioned this pull request Apr 24, 2017
Closed
2 of 5 tasks complete
@jdm
Copy link
Member

jdm commented Apr 24, 2017

@bors-servo: r+
Looks good!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

📌 Commit 2c6bd51 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

⌛ Testing commit 2c6bd51 with merge 4263b79...
bors-servo added a commit that referenced this pull request Apr 24, 2017
@bors-servo
Auto merge of #16592 - avadacatavra:globalscope, r=jdm
Loading status checks…
4263b79 
added origin to globalscope

<!-- Please describe your changes on the following line: -->
Replaces #16561

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16592)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 4263b79 to master...
@bors-servo bors-servo merged commit 2c6bd51 into servo:master Apr 24, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 24, 2017
Closed
0 of 5 tasks complete
@fnune fnune mentioned this pull request Apr 24, 2017
Merged
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@avadacatavra @highfive @jdm @bors-servo
You can’t perform that action at this time.