Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade selectors not() behavior to level 3 #16606

Merged
merged 1 commit into from Apr 25, 2017
Merged

Downgrade selectors not() behavior to level 3 #16606

merged 1 commit into from Apr 25, 2017

Conversation

@bholley
Copy link
Contributor

bholley commented Apr 25, 2017 •
edited by larsbergstrom

https://bugzilla.mozilla.org/show_bug.cgi?id=1348802

This change is Reviewable
@bholley
Copy link
Contributor Author

bholley commented Apr 25, 2017

@bors-servo r=SimonSapin p=1
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

📌 Commit 2264412 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned pcwalton Apr 25, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

⌛ Testing commit 2264412 with merge bd48bf5...
bors-servo added a commit that referenced this pull request Apr 25, 2017
@bors-servo
Auto merge of #16606 - bholley:not_selector_level_3, r=SimonSapin
Loading status checks…
bd48bf5 
Downgrade selectors not() behavior to level 3

https://bugzilla.mozilla.org/show_bug.cgi?id=1348802
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Apr 25, 2017

This is hitting the problem that #16602 describes.
@bholley
Copy link
Contributor Author

bholley commented Apr 25, 2017

@Manishearth any idea what's going on here?
@jdm
Copy link
Member

jdm commented Apr 25, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

⌛ Testing commit 2264412 with merge 506a9a0ab39b2f4bc42b60d30ee8bcc6f3134be9...
@Manishearth
Copy link
Member

Manishearth commented Apr 25, 2017

@bors-servo retry

  • infra 😢
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

⌛ Testing commit 2264412 with merge 0110673...
bors-servo added a commit that referenced this pull request Apr 25, 2017
@bors-servo
Auto merge of #16606 - bholley:not_selector_level_3, r=SimonSapin
Loading status checks…
0110673 
Downgrade selectors not() behavior to level 3

https://bugzilla.mozilla.org/show_bug.cgi?id=1348802

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16606)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

SimonSapin commented Apr 25, 2017

I think retrying is not gonna help, the builders’s target directory are in a state that is broken for compiletest.

Let me try something in #16601…
@Manishearth
Copy link
Member

Manishearth commented Apr 25, 2017

Yes, and I blew away the offending files on the builder a few hours ago
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

💔 Test failed - linux-dev
@SimonSapin
Copy link
Member

SimonSapin commented Apr 25, 2017

the offending files

Did you try to do it selectively? If so it might be easier to remove the entire target dir, on all builders.
@Manishearth
Copy link
Member

Manishearth commented Apr 25, 2017

I did it selectively, and a PR landed. The dir got polluted again, probably due to the cargo PR?
@SimonSapin
Copy link
Member

SimonSapin commented Apr 25, 2017

#16601 last ran on CI 10 hours ago.

on all builders.

Or at least the six servo-linux-* builders. They’re the ones that semi-randomly get assigned linux-dev jobs, which is the only one that runs compile tests.
@Manishearth
Copy link
Member

Manishearth commented Apr 25, 2017

Ah, fair.
@bholley
Downgrade selectors not() behavior to level 3.
Loading status checks…
a1e90d1 
MozReview-Commit-ID: 6p750Ml2wzm
@bholley bholley force-pushed the bholley:not_selector_level_3 branch from 2264412 to a1e90d1 Apr 25, 2017
@bholley
Copy link
Contributor Author

bholley commented Apr 25, 2017

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

📌 Commit a1e90d1 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

⌛ Testing commit a1e90d1 with merge 9059c1d...
bors-servo added a commit that referenced this pull request Apr 25, 2017
@bors-servo
Auto merge of #16606 - bholley:not_selector_level_3, r=SimonSapin
Loading status checks…
9059c1d 
Downgrade selectors not() behavior to level 3

https://bugzilla.mozilla.org/show_bug.cgi?id=1348802

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: SimonSapin
Pushing 9059c1d to master...
@bors-servo bors-servo merged commit a1e90d1 into servo:master Apr 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bholley @bors-servo @jdm @Manishearth @SimonSapin @pcwalton @highfive
You can’t perform that action at this time.