Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unitless length quirk #16609

Merged
merged 22 commits into from Apr 28, 2017
Merged

Implement unitless length quirk #16609

merged 22 commits into from Apr 28, 2017
+2,321 −194

Conversation

@nox
Copy link
Member

nox commented Apr 25, 2017 •
edited by edunham

The Gecko side doesn't propagate its quirks mode yet.

This change is Reviewable
@highfive
Copy link

highfive commented Apr 25, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/specified/length.rs and 28 more
  • @jgraham: tests/wpt/include.ini
  • @KiChjang: components/script/dom/htmlmetaelement.rs, components/script/dom/window.rs, components/script/dom/css.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs and 9 more
  • @fitzgen: components/script/dom/htmlmetaelement.rs, components/script/dom/window.rs, components/script/dom/css.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs and 9 more
  • @emilio: ports/geckolib/glue.rs, components/style/stylesheets.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs and 29 more
@Manishearth
Manishearth reviewed Apr 25, 2017
View changes
components/style/values/specified/length.rs Outdated
}
Ok(LengthOrPercentage::Length(NoCalcLength::Absolute(AbsoluteLength::Px(value.value))))
}
Token::Number(ref value) if value.value == 0. ||

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2017

Member

nit: parehtneses over precedence
@Manishearth
Copy link
Member

Manishearth commented Apr 25, 2017

r=me with those parens set.
@nox nox force-pushed the nox:quirks branch 2 times, most recently from 874cc15 to 25d2fbb Apr 25, 2017
@nox
Copy link
Member Author

nox commented Apr 25, 2017

@bors-servo r=Manishearth p=17
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

📌 Commit 25d2fbb has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

⌛ Testing commit 25d2fbb with merge 83884ec...
bors-servo added a commit that referenced this pull request Apr 25, 2017
@bors-servo
Auto merge of #16609 - nox:quirks, r=Manishearth
Loading status checks…
83884ec 
Implement unitless length quirk

The Gecko side doesn't propagate its quirks mode yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

💔 Test failed - windows-msvc-dev
@nox nox force-pushed the nox:quirks branch from 25d2fbb to e3f80cc Apr 26, 2017
@nox nox force-pushed the nox:quirks branch from e3f80cc to 65a0d89 Apr 26, 2017
@nox
Copy link
Member Author

nox commented Apr 26, 2017

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2017

📌 Commit 65a0d89 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2017

⌛ Testing commit 65a0d89 with merge 96d896a...
bors-servo added a commit that referenced this pull request Apr 26, 2017
@bors-servo
Auto merge of #16609 - nox:quirks, r=Manishearth
Loading status checks…
96d896a 
Implement unitless length quirk

The Gecko side doesn't propagate its quirks mode yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2017

💔 Test failed - windows-msvc-dev
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

💔 Test failed - linux-rel-css
@nox
Copy link
Member Author

nox commented Apr 27, 2017

Build is broken?

@bors-servo retry
@chenpighead
Copy link
Contributor

chenpighead commented Apr 27, 2017

I believe you're hitting #16632... which I also hit it for hours.... :-(
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

⌛ Testing commit 1091af6 with merge 1d4cb4b...
bors-servo added a commit that referenced this pull request Apr 27, 2017
@bors-servo
Auto merge of #16609 - nox:quirks, r=Manishearth,emilio
Loading status checks…
1d4cb4b 
Implement unitless length quirk

The Gecko side doesn't propagate its quirks mode yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

💔 Test failed - linux-dev
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

⌛ Testing commit 1091af6 with merge bdf74ef...
bors-servo added a commit that referenced this pull request Apr 27, 2017
@bors-servo
Auto merge of #16609 - nox:quirks, r=Manishearth,emilio
Loading status checks…
bdf74ef 
Implement unitless length quirk

The Gecko side doesn't propagate its quirks mode yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

💔 Test failed - arm32
@jdm
Copy link
Member

jdm commented Apr 28, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2017

⌛ Testing commit 1091af6 with merge d8bcc0d...
bors-servo added a commit that referenced this pull request Apr 28, 2017
@bors-servo
Auto merge of #16609 - nox:quirks, r=Manishearth,emilio
Loading status checks…
d8bcc0d 
Implement unitless length quirk

The Gecko side doesn't propagate its quirks mode yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: Manishearth,emilio
Pushing d8bcc0d to master...
@bors-servo bors-servo merged commit 1091af6 into servo:master Apr 28, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:quirks branch Apr 28, 2017
jdm added a commit to web-platform-tests/wpt that referenced this pull request Jun 19, 2017
@nox @jdm
Run a test per property and value in unitless-length.html
58abd30 
Upstreamed from servo/servo#16609 [ci skip]
@jdm jdm mentioned this pull request Jun 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@nox @highfive @Manishearth @bors-servo @wafflespeanut @chenpighead @jdm
You can’t perform that action at this time.