Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMIL support for Gecko #16625

Merged
merged 5 commits into from Apr 27, 2017
Merged

SMIL support for Gecko #16625

merged 5 commits into from Apr 27, 2017

Conversation

@birtles
Copy link
Contributor

birtles commented Apr 27, 2017 •
edited by larsbergstrom

PR for Gecko bug 1355348

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they are tested on the Gecko side

This change is Reviewable
@birtles
Add SMIL override cascade level
97ce9ed
@highfive
Copy link

highfive commented Apr 27, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/restyle_hints.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs and 2 more
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs, components/style/restyle_hints.rs, components/style/rule_tree/mod.rs, components/style/dom.rs and 3 more
@highfive
Copy link

highfive commented Apr 27, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@birtles
Copy link
Contributor Author

birtles commented Apr 27, 2017

These patches have been approved by @hiikezoe (hiro) and @heycam.
birtles added 4 commits Apr 27, 2017
@birtles
Get SMIL override styles from Gecko
2c3c9d6
@birtles
Rename remove_animation_and_transition_rules to just remove_animation…
ba118df 
…_rules

Now this method covers SMIL override rules, CSS animation / script
animation rules, and CSS transition rules so we should just use
"animation" in the generic sense.
@birtles
Add restyle hint for SMIL animations
af9c7fc
@birtles
Make Servo_NoteExplicitHints allow multiple animation restyle hints, …
Loading status checks…
42cc886 
…including SMIL

The existing code here appears to be wrong since we should allow *both*
animation and transition restyles to appear at the same time. This patch
fixes the assertion and subsequent check and also extends it to support
all animation restyle hints, including SMIL.
@birtles birtles force-pushed the birtles:smil-support branch from 899d67e to 42cc886 Apr 27, 2017
@heycam
Copy link
Member

heycam commented Apr 27, 2017

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

✌️ @birtles can now approve this pull request
@birtles
Copy link
Contributor Author

birtles commented Apr 27, 2017

@bors-servo r=hiro,heycam p=10
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

📌 Commit 42cc886 has been approved by hiro,heycam
@birtles
Copy link
Contributor Author

birtles commented Apr 27, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

⌛ Trying commit 42cc886 with merge 896f943...
bors-servo added a commit that referenced this pull request Apr 27, 2017
@bors-servo
Auto merge of #16625 - birtles:smil-support, r=<try>
Loading status checks…
896f943 
SMIL support for Gecko

PR for [Gecko bug 1355348](https://bugzilla.mozilla.org/show_bug.cgi?id=1355348)

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they are tested on the Gecko side

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16625)
<!-- Reviewable:end -->
@birtles
Copy link
Contributor Author

birtles commented Apr 27, 2017

@bors-servo r=hiro,heycam
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #16622
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

📌 Commit 42cc886 has been approved by hiro,heycam
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

⌛ Testing commit 42cc886 with merge 8824a68...
bors-servo added a commit that referenced this pull request Apr 27, 2017
@bors-servo
Auto merge of #16625 - birtles:smil-support, r=hiro,heycam
Loading status checks…
8824a68 
SMIL support for Gecko

PR for [Gecko bug 1355348](https://bugzilla.mozilla.org/show_bug.cgi?id=1355348)

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they are tested on the Gecko side

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16625)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: hiro,heycam
Pushing 8824a68 to master...
@bors-servo bors-servo merged commit 42cc886 into servo:master Apr 27, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@birtles @highfive @heycam @bors-servo @KiChjang
You can’t perform that action at this time.