Fix broken unit tests

[jdm]

These are tests that only get run on TravisCI, apparently, so they were broken by be0139f and 32c624e without anybody noticing.

---

This change is 

[highfive]

Heads up! This PR modifies the following files:

• @bholley: components/style/restyle_hints.rs
• @emilio: components/style/restyle_hints.rs

[highfive]

Warning

• These commits modify style code, but no tests are modified. Please consider adding a test!

[emilio]

The signature of note_selector changed, so this is probably not sufficient. :(

[SimonSapin]

Could you also make ./mach test-unit run these test? So that we don’t regress them again. I think this involves either:

• In python/servo/testing_commands.py:

  • adding selectors to this set:

        if not packages:
            packages = set(os.listdir(path.join(self.context.topdir, "tests", "unit"))) - set(['.DS_Store'])

  • and adding an exception in this

            for crate in packages:
                args += ["-p", "%s_tests" % crate]

• Or moving the tests to a new selectors_tests crate in tests/unit/selectors.

[bors-servo]

☔ The latest upstream changes (presumably #16659) made this pull request unmergeable. Please resolve the merge conflicts.

[bholley]

I fixed the selectors tests in #16659

[jdm]

I've made test-unit run the tests in components/selectors and components/style, and test-unit -p style also runs it.

[SimonSapin]

and components/style

Is there any unit tests there? If so we should move them to tests/unit/style instead.

The point of having separate crates for unit tests is to reduce compile times by not compiling large crates like style with rustc --test. (This is less of a concern with selectors which is not as large, and might move back out of the servo/servo repo at some point.)

[jdm]

@emilio Why did a0c2bdf add a smoke test inside components/style?

[emilio]

I believe the idea was not exposing all the stuff in restyle_hints.rs, but I guess given we've already given up on that for the rest of the crate, it doesn't make a lot of sense, so I'll move it to tests/unit/style.

[jdm]

$ ./mach test-unit -p selectors

error: package id specification `selectors_tests` matched no packages

The command "./mach test-unit -p selectors" exited with 101.

56.57s$ ./mach cargo test -p style

   Compiling style v0.0.1 (file:///home/travis/build/servo/servo/components/style)

    Finished dev [unoptimized + debuginfo] target(s) in 54.81 secs

     Running /home/travis/build/servo/servo/target/debug/deps/style-b8435dc72cbcc33f

running 1 test

test restyle_hints::smoke_restyle_hints ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured

[jdm]

I moved the unit test out of component/style and into tests/unit/style.

[cbrewster]

From Travis:

$ ./mach test-unit -p selectors
error: package id specification `selectors_tests` matched no packages
The command "./mach test-unit -p selectors" exited with 101.

[jdm]

Travis used an old revision for some reason. That error is impossible with the current code.

[emilio]

@bors-servo r+

Thanks for this :)

[bors-servo]

📌 Commit fbe0eef has been approved by emilio

[jdm]

@bors-servo: r-
I want to figure out what Appveyor does not like.

[jdm]

@bors-servo: r=emilio

[bors-servo]

📌 Commit f3f9e28 has been approved by emilio

[bors-servo]

⌛ Testing commit f3f9e28 with merge 3905b5a...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 3905b5a to master...