Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to gradients. #16666

Merged
merged 7 commits into from May 7, 2017
Merged

Improvements to gradients. #16666

merged 7 commits into from May 7, 2017

Commits on Apr 30, 2017

  1. Implement -webkit-radial-gradient aliases.

    In display_list_builder.rs handle cover and contain size keywords.
    pyfisch committed Apr 30, 2017
  2. Improve convert_gradient_stops function.

    Implement Specification from CSS Images 3.
    
    Improvements:
    
    1. Stops with positions less than preceding stops are moved.
         A common pattern is blue `70%, white 0` for sharp transitions.
    2. Stop runs are correct if first stop has a position.
        The list `black 0%, red, gold` now renders the same as `black, red, gold`.
        Other runs may also be corrected.
    3. Absolute length are no longer capped to 100%.
    pyfisch committed Apr 30, 2017
  3. Implement radial gradients for borders.

    The property border-image-outset is not yet implemented.
    Note: Also support repeating-linear-gradients for borders.
    pyfisch committed Apr 30, 2017

Commits on May 1, 2017

  1. Add fix_gradient_stops function.

    Render gradients where the last stop is the same position
    as the previous one like Chrome and Firefox do.
    pyfisch committed May 1, 2017
  2. Correct virtual gradient ray length of radial gradients.

    The length should be the horizontal radius and not the
    hypotenuse.
    pyfisch committed May 1, 2017

Commits on May 6, 2017

  1. Duplicate first gradient stop if necessary.

    If the first stop of a non-repeating gradient is
    not placed at offset 0.0 it is duplicated at this
    position. This solves the problem of the first
    stop being ignored if it is placed at the same
    offset as the next stop.
    pyfisch committed May 6, 2017

Commits on May 7, 2017

  1. Address feedback by emilio.

    pyfisch committed May 7, 2017
You can’t perform that action at this time.