Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace intrinsics::abort with process::abort #16680
Merged
Conversation
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 1, 2017
Replace intrinsics::abort with process::abort This removes some unsafe/unstable code and replaces it with a new safe/stable alternative. Note that `process::abort` is not identical to `intrinsics::abort`, since it runs global cleanups to do things like flush stderr (though neither function performs stack unwinding). I don't *think* the difference matters for our use cases. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change functionality <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16680) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
May 16, 2017
Revert "Replace intrinsics::abort with process::abort" This reverts #16680. Calling `process::abort` from the crash handler causes the crash handler to be invoked again recursively. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16898 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16899) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 1, 2017
•
edited by larsbergstrom
This removes some unsafe/unstable code and replaces it with a new safe/stable alternative.
Note that
process::abortis not identical tointrinsics::abort, since it runs global cleanups to do things like flush stderr (though neither function performs stack unwinding). I don't think the difference matters for our use cases../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is