Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using unstable slice_patterns feature #16681

Merged
merged 1 commit into from May 2, 2017
Merged

Stop using unstable slice_patterns feature #16681

merged 1 commit into from May 2, 2017
+5 −10

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented May 1, 2017 •
edited by larsbergstrom

cc #5286

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes OR
  • These changes do not require tests because no functionality changed

This change is Reviewable
@mbrubeck
Stop using unstable slice_patterns feature
Loading status checks…
10478b4
@highfive
Copy link

highfive commented May 1, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/nodelist.rs, components/script/lib.rs, components/script_plugins/lib.rs
  • @KiChjang: components/script/dom/nodelist.rs, components/script/lib.rs, components/script_plugins/lib.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs and 2 more
@highfive
Copy link

highfive commented May 1, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented May 1, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2017

📌 Commit 10478b4 has been approved by emilio
@highfive highfive assigned emilio and unassigned KiChjang May 1, 2017
@mbrubeck mbrubeck mentioned this pull request May 1, 2017
Closed
90 of 99 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2017

⌛ Testing commit 10478b4 with merge fcc9d79...
bors-servo added a commit that referenced this pull request May 1, 2017
@bors-servo
Auto merge of #16681 - mbrubeck:slice_patterns, r=emilio
Loading status checks…
fcc9d79 
Stop using unstable slice_patterns feature

cc #5286

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no functionality changed

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16681)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2017

💔 Test failed - linux-rel-css
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 1, 2017

@bors-servo r- try
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 1, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2017

⌛ Trying commit 10478b4 with merge 294b422...
bors-servo added a commit that referenced this pull request May 1, 2017
@bors-servo
Auto merge of #16681 - mbrubeck:slice_patterns, r=<try>
Loading status checks…
294b422 
Stop using unstable slice_patterns feature

cc #5286

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no functionality changed

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16681)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
State: approved= try=True
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 2, 2017

@bors-servo try- r=emilio retry

Filed #16685 for the intermittent.
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

📌 Commit 10478b4 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

⌛ Testing commit 10478b4 with merge 4426236...
bors-servo added a commit that referenced this pull request May 2, 2017
@bors-servo
Auto merge of #16681 - mbrubeck:slice_patterns, r=emilio
Loading status checks…
4426236 
Stop using unstable slice_patterns feature

cc #5286

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no functionality changed

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16681)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 4426236 to master...
@bors-servo bors-servo merged commit 10478b4 into servo:master May 2, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:slice_patterns branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @highfive @emilio @bors-servo @KiChjang
You can’t perform that action at this time.