Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to html5ever 0.16 #16689

Merged
merged 1 commit into from May 3, 2017
Merged

Upgrade to html5ever 0.16 #16689

merged 1 commit into from May 3, 2017
+363 −471

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 2, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented May 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs
  • @KiChjang: components/script/dom/svgelement.rs, components/script/dom/htmlbrelement.rs, components/script/dom/htmlulistelement.rs, components/script/dom/htmlfieldsetelement.rs, components/script/dom/servoparser/html.rs and 90 more
  • @fitzgen: components/script/dom/svgelement.rs, components/script/dom/htmlbrelement.rs, components/script/dom/htmlulistelement.rs, components/script/dom/htmlfieldsetelement.rs, components/script/dom/servoparser/html.rs and 90 more
  • @emilio: components/style/Cargo.toml, components/style/lib.rs, components/layout/Cargo.toml, components/layout/lib.rs
@SimonSapin
Copy link
Member Author

SimonSapin commented May 2, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

⌛ Trying commit 9ab3cd2 with merge fd5f55e...
bors-servo added a commit that referenced this pull request May 2, 2017
@bors-servo
Auto merge of #16689 - servo:m5e, r=<try>
Loading status checks…
fd5f55e 
[Do not merge yet] Upgrade to html5ever 0.16
@SimonSapin SimonSapin mentioned this pull request May 2, 2017
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

💔 Test failed - mac-dev-unit
@SimonSapin
Copy link
Member Author

SimonSapin commented May 2, 2017 

./mach package --dev
hdiutil: create failed - error -5341
Creating Servo.app
Copying files
Swapping prefs
Finding dylibs and relinking
Adding version to Credits.rtf
Writing run-servo
Creating dmg
Packaging MacOS dmg exited with return value 1

I… have no idea what this means. Let’s see if it happens again:

@bors-servo try retry
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

⌛ Trying commit 9ab3cd2 with merge b59a038...
bors-servo added a commit that referenced this pull request May 2, 2017
@bors-servo
Auto merge of #16689 - servo:m5e, r=<try>
Loading status checks…
b59a038 
[Do not merge yet] Upgrade to html5ever 0.16

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16689)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
State: approved= try=True
@jdm
Copy link
Member

jdm commented May 2, 2017

That's #16644.
@SimonSapin
Upgrade to html5ever 0.16
Loading status checks…
6c518c8
@highfive highfive removed the S-tests-failed label May 2, 2017
@SimonSapin SimonSapin changed the title [Do not merge yet] Upgrade to html5ever 0.16 Upgrade to html5ever 0.16 May 2, 2017
@SimonSapin
Copy link
Member Author

SimonSapin commented May 2, 2017

This is ready to land. r? @nox
@nox
Copy link
Member

nox commented May 3, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2017

📌 Commit 6c518c8 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2017

⌛ Testing commit 6c518c8 with merge c587000...
bors-servo added a commit that referenced this pull request May 3, 2017
@bors-servo
Auto merge of #16689 - servo:m5e, r=nox
Loading status checks…
c587000 
Upgrade to html5ever 0.16

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16689)
<!-- Reviewable:end -->
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 3, 2017

@bors-servo force clean retry
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2017

⌛ Testing commit 6c518c8 with merge 8b41c7c...
bors-servo added a commit that referenced this pull request May 3, 2017
@bors-servo
Auto merge of #16689 - servo:m5e, r=nox
Loading status checks…
8b41c7c 
Upgrade to html5ever 0.16

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16689)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: nox
Pushing 8b41c7c to master...
@bors-servo bors-servo merged commit 6c518c8 into master May 3, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced May 3, 2017
Closed
Merged
@notriddle notriddle deleted the m5e branch May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @bors-servo @jdm @nox @larsbergstrom
You can’t perform that action at this time.