Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make History attributes and methods throw #16697

Merged
merged 1 commit into from May 5, 2017
Merged

Make History attributes and methods throw #16697

merged 1 commit into from May 5, 2017

Conversation

@cbrewster
Copy link
Member

cbrewster commented May 2, 2017 •
edited by larsbergstrom

All History methods and attributes should throw a SecurityError if the document associated with the History object is not fully active.
https://html.spec.whatwg.org/multipage/browsers.html#history-3

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@cbrewster
Make History attributes and methods throw
Loading status checks…
5c53f5b
@highfive
Copy link

highfive commented May 2, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/history.rs, components/script/dom/webidls/History.webidl
  • @KiChjang: components/script/dom/history.rs, components/script/dom/webidls/History.webidl
@highfive
Copy link

highfive commented May 2, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@cbrewster
Copy link
Member Author

cbrewster commented May 4, 2017

r? @asajeffrey or anyone
@highfive highfive assigned asajeffrey and unassigned wafflespeanut May 4, 2017
@KiChjang
Copy link
Member

KiChjang commented May 4, 2017

@bors-servo r+

I suspect that we may have passing tests; if so, just update the expectations and r=me again.
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

📌 Commit 5c53f5b has been approved by KiChjang
@highfive highfive assigned KiChjang and unassigned asajeffrey May 4, 2017
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

⌛ Testing commit 5c53f5b with merge 4bdbc28100801dea3a85dabc8887c9a97590c04c...
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

💔 Test failed - linux-dev
@KiChjang
Copy link
Member

KiChjang commented May 4, 2017

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2017

⌛ Testing commit 5c53f5b with merge ca2a502...
bors-servo added a commit that referenced this pull request May 4, 2017
@bors-servo
Auto merge of #16697 - cbrewster:history_throw, r=KiChjang
Loading status checks…
ca2a502 
Make History attributes and methods throw

<!-- Please describe your changes on the following line: -->
All History methods and attributes should throw a `SecurityError` if the document associated with the `History` object is not fully active.
https://html.spec.whatwg.org/multipage/browsers.html#history-3

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16697)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: KiChjang
Pushing ca2a502 to master...
@bors-servo bors-servo merged commit 5c53f5b into servo:master May 5, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@cbrewster
Copy link
Member Author

cbrewster commented May 5, 2017

Hmm no tests for these; however, I don't know how we would make a test that makes calls to the History object on a non fully-active document.
@cbrewster cbrewster deleted the cbrewster:history_throw branch May 5, 2017
@cbrewster cbrewster mentioned this pull request May 20, 2017
Open
18 of 24 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@cbrewster @highfive @KiChjang @bors-servo @asajeffrey @wafflespeanut
You can’t perform that action at this time.