Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stylo support moz-prefixed cursor values. #16733

Merged
merged 1 commit into from May 5, 2017
Merged

Conversation

@kuoe0
Copy link
Contributor

kuoe0 commented May 5, 2017

This issue is reported at https://bugzilla.mozilla.org/show_bug.cgi?id=1356072.

We need to support the following moz-prefix properties in stylo:

  • -moz-grab
  • -moz-grabbing
  • -moz-zoom-in
  • -moz-zoom-out

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1356072.
  • These changes do not require tests because the tests already exist in Gecko.

This change is Reviewable

MozReview-Commit-ID: AfV0recnoXw
@highfive

This comment has been minimized.

Copy link

highfive commented May 5, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/properties/gecko.mako.rs
  • @emilio: components/style/Cargo.toml, components/style/properties/gecko.mako.rs
@highfive

This comment has been minimized.

Copy link

highfive commented May 5, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@heycam

This comment has been minimized.

Copy link
Member

heycam commented May 5, 2017

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2017

✌️ @kuoe0 can now approve this pull request

@kuoe0

This comment has been minimized.

Copy link
Contributor Author

kuoe0 commented May 5, 2017

@bors-servo r=xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2017

📌 Commit 285ff82 has been approved by xidorn

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2017

⌛️ Testing commit 285ff82 with merge 8187969...

bors-servo added a commit that referenced this pull request May 5, 2017
Make stylo support moz-prefixed cursor values.

<!-- Please describe your changes on the following line: -->

This issue is reported at https://bugzilla.mozilla.org/show_bug.cgi?id=1356072.

We need to support the following moz-prefix properties in stylo:
- -moz-grab
- -moz-grabbing
- -moz-zoom-in
- -moz-zoom-out

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1356072](https://bugzilla.mozilla.org/show_bug.cgi?id=1356072).

<!-- Either: -->
- [X] These changes do not require tests because the tests already exist in Gecko.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16733)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: xidorn
Pushing 8187969 to master...

@bors-servo bors-servo merged commit 285ff82 into servo:master May 5, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.