Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07) #16756

Merged
merged 1 commit into from May 8, 2017
Merged

Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07) #16756

merged 1 commit into from May 8, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 7, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented May 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @KiChjang: components/script/dom/bindings/weakref.rs, components/script/dom/bindings/js.rs, components/script/layout_wrapper.rs
  • @fitzgen: components/script/dom/bindings/weakref.rs, components/script/dom/bindings/js.rs, components/script/layout_wrapper.rs
  • @emilio: components/style/Cargo.toml, components/layout/wrapper.rs
@highfive
Copy link

highfive commented May 7, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style, layout, gfx, and script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented May 7, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2017

📌 Commit d21d256 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2017

⌛ Testing commit d21d256 with merge 575b59b...
bors-servo added a commit that referenced this pull request May 7, 2017
@bors-servo
Auto merge of #16756 - servo:rustup, r=jdm
Loading status checks…
575b59b 
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 7, 2017

💔 Test failed - android
@SimonSapin
Copy link
Member Author

SimonSapin commented May 7, 2017

Extract that seems relevant of the error messages:

error: failed to run custom build command for `blurdroid v0.1.2`
process didn't exit successfully: `/home/servo/buildbot/slave/android/build/target/debug/build/blurdroid-e2727e499c92c405/build-script-build` (exit code: 1)
--- stdout
make: Entering directory `/home/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/blurdroid-0.1.2/src/jni'
make: Leaving directory `/home/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/blurdroid-0.1.2/src/jni'
Error while executing javac

--- stderr
src/java/hu/uszeged/bluetooth/ScanRecord.java:25: error: package android.os does not exist
import android.os.ParcelUuid;
                 ^
src/java/hu/uszeged/bluetooth/ScanRecord.java:26: error: package android.util does not exist
import android.util.SparseArray;
                   ^

@larsbergstrom Have you seen this before?
@SimonSapin
Copy link
Member Author

SimonSapin commented May 7, 2017 •
edited

Also depends on laumann/compiletest-rs#63
@SimonSapin
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)
Loading status checks…
02e1901
@SimonSapin SimonSapin force-pushed the rustup branch from d21d256 to 02e1901 May 8, 2017
@SimonSapin SimonSapin mentioned this pull request May 8, 2017
Merged
@jdm
Copy link
Member

jdm commented May 8, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

📌 Commit 02e1901 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Testing commit 02e1901 with merge 2b267ca...
bors-servo added a commit that referenced this pull request May 8, 2017
@bors-servo
Auto merge of #16756 - servo:rustup, r=jdm
Loading status checks…
2b267ca 
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented May 8, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Testing commit 02e1901 with merge 1970608...
bors-servo added a commit that referenced this pull request May 8, 2017
@bors-servo
Auto merge of #16756 - servo:rustup, r=jdm
Loading status checks…
1970608 
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 1970608 to master...
@bors-servo bors-servo merged commit 02e1901 into master May 8, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the rustup branch May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @highfive @jdm @bors-servo
You can’t perform that action at this time.