Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate atom files at build-time #16762

Merged
merged 8 commits into from May 8, 2017
Merged

Generate atom files at build-time #16762

merged 8 commits into from May 8, 2017

Conversation

@upsuper
Copy link
Member

upsuper commented May 8, 2017 •
edited by larsbergstrom

The commits here basically do the following things:

  1. move all generated files for gecko into "gecko/generated" so that we can copy all of them around
  2. make regen_atoms.py generate file to the out dir rather than in-tree
  3. make the build script invoke regen_atoms.py when bindgen feature is enabled

This change is Reviewable
@upsuper
Expose a single function for bindings mod in build_gecko.
1d6ede3
@highfive
Copy link

highfive commented May 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko/generated/pseudo_element_helper.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko/generated/bindings.rs and 10 more
  • @wafflespeanut: python/servo/build_commands.py
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko/generated/pseudo_element_helper.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko/generated/bindings.rs and 10 more
@highfive
Copy link

highfive commented May 8, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

r? @emilio
@highfive highfive assigned emilio and unassigned pcwalton May 8, 2017
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

This is something I've promised to do since long ago...
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Trying commit 6b38d39 with merge 11eb9c3f1a98b307a672c08d4e7886247c27bc3e...
@upsuper
Stop touching in-tree files from build-geckolib.
35dc68c 
This stops:
* generating atom helper files from regen_atoms.py
* copying generated binding files to in-tree
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo try-
@upsuper upsuper force-pushed the upsuper-forks:buildtime-pseudo branch from 6b38d39 to a7e9374 May 8, 2017
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Trying commit a7e9374 with merge 9035e8f...
bors-servo added a commit that referenced this pull request May 8, 2017
@bors-servo
Auto merge of #16762 - upsuper:buildtime-pseudo, r=<try>
Loading status checks…
9035e8f 
Generate atom files at build-time

The commits here basically do the following things:
1. move all generated files for gecko into "gecko/generated" so that we can copy all of them around
2. make regen_atoms.py generate file to the out dir rather than in-tree
3. make the build script invoke regen_atoms.py when bindgen feature is enabled

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16762)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

💔 Test failed - android
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Trying commit a7e9374 with merge c74f708...
bors-servo added a commit that referenced this pull request May 8, 2017
@bors-servo
Auto merge of #16762 - upsuper:buildtime-pseudo, r=<try>
Loading status checks…
c74f708 
Generate atom files at build-time

The commits here basically do the following things:
1. move all generated files for gecko into "gecko/generated" so that we can copy all of them around
2. make regen_atoms.py generate file to the out dir rather than in-tree
3. make the build script invoke regen_atoms.py when bindgen feature is enabled

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16762)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

💔 Test failed - android
@emilio
emilio approved these changes May 8, 2017
View changes
@emilio
Copy link
Member

emilio commented May 8, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

📌 Commit a7e9374 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

📌 Commit 3abf662 has been approved by emilio
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo r-

There are other tests need to be fixed first.
upsuper added 5 commits May 8, 2017
@upsuper
Rename gecko_ prefix of pseudo_element_helper file.
869e5e0
@upsuper
Move atom_macro.rs to generated dir.
5b57c55
@upsuper
Move python path into a lazy static.
d44b904
@upsuper
Make atom files generated at build-time.
10b7001
@upsuper
Copy all generated files to dist dir for packaging.
Loading status checks…
ff76ec8
@upsuper upsuper force-pushed the upsuper-forks:buildtime-pseudo branch from 3abf662 to ff76ec8 May 8, 2017
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Trying commit ff76ec8 with merge c5f0938...
bors-servo added a commit that referenced this pull request May 8, 2017
@bors-servo
Auto merge of #16762 - upsuper:buildtime-pseudo, r=<try>
Loading status checks…
c5f0938 
Generate atom files at build-time

The commits here basically do the following things:
1. move all generated files for gecko into "gecko/generated" so that we can copy all of them around
2. make regen_atoms.py generate file to the out dir rather than in-tree
3. make the build script invoke regen_atoms.py when bindgen feature is enabled

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16762)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

💔 Test failed - android
@upsuper
Copy link
Member Author

upsuper commented May 8, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

📌 Commit ff76ec8 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

⌛ Testing commit ff76ec8 with merge a5fe464...
bors-servo added a commit that referenced this pull request May 8, 2017
@bors-servo
Auto merge of #16762 - upsuper:buildtime-pseudo, r=emilio
Loading status checks…
a5fe464 
Generate atom files at build-time

The commits here basically do the following things:
1. move all generated files for gecko into "gecko/generated" so that we can copy all of them around
2. make regen_atoms.py generate file to the out dir rather than in-tree
3. make the build script invoke regen_atoms.py when bindgen feature is enabled

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16762)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing a5fe464 to master...
@bors-servo bors-servo merged commit ff76ec8 into servo:master May 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:buildtime-pseudo branch May 8, 2017
@bors-servo bors-servo mentioned this pull request May 8, 2017
Merged
@upsuper upsuper mentioned this pull request Oct 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@upsuper @highfive @bors-servo @emilio @pcwalton
You can’t perform that action at this time.