Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to re-enable unit tests on travis-ci #16767

Merged
merged 2 commits into from May 9, 2017
Merged

Try to re-enable unit tests on travis-ci #16767

merged 2 commits into from May 9, 2017

Conversation

@UK992
Copy link
Contributor

UK992 commented May 8, 2017

After #16573 and #16593, issue #15076 could be fixed.

Edit:
Closes #14723
Closes #15076


This change is Reviewable

#- ./mach build-geckolib
#- ./mach test-stylo
- ./mach test-unit
- ./mach clean

This comment has been minimized.

Copy link
@jdm

jdm May 8, 2017

Member

Why is the clean necessary?

This comment has been minimized.

Copy link
@jdm

jdm May 8, 2017

Member

Oh, that frees up all the space used by the non-geckolib build, doesn't it?

This comment has been minimized.

Copy link
@UK992

UK992 May 8, 2017

Author Contributor

Yes.

@jdm
Copy link
Member

jdm commented May 8, 2017

This looks good to me if it's squashed.

@jdm jdm added S-needs-squash and removed S-awaiting-review labels May 8, 2017
@UK992 UK992 force-pushed the UK992:travis branch from e475e4b to 3f67037 May 8, 2017
@UK992
Copy link
Contributor Author

UK992 commented May 8, 2017

Squashed.

@jdm
Copy link
Member

jdm commented May 8, 2017

@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2017

📌 Commit 3f67037 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

Testing commit 3f67037 with merge 8ff484d...

bors-servo added a commit that referenced this pull request May 9, 2017
Try to re-enable unit tests on travis-ci

After #16573 and #16593, issue #15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16767)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 8ff484d to master...

@bors-servo bors-servo merged commit 3f67037 into servo:master May 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.