Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport for Android armv7 and aarch64 target triples #16769
Merged
+144
−33
Conversation
highfive
commented
May 8, 2017
|
Heads up! This PR modifies the following files:
|
This was referenced May 8, 2017
bors-servo
added a commit
to servo/mozjs
that referenced
this pull request
May 8, 2017
Support for Android armv7 and aarch64 target triples See servo/servo#11921 and servo/servo#16769 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/118) <!-- Reviewable:end -->
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 13, 2017
Support for Android armv7 and aarch64 target triples <!-- Please describe your changes on the following line: --> Support for Android armv7 and aarch64 target triples in python build scripts (build + packaging) `--android` build parameter works as always (arm-linux-androideabi still the default) `./mach build --release --android` New compilation modes for android `./mach build --release --target=arm-linux-androideabi` `./mach build --release --target=armv7-linux-androideabi` `./mach build --release --target=aarch64-linux-android` See #11921. When all crates are ready we'll switch default android compilations to` armv7-linux-androideabi` target triple. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16769) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedMay 8, 2017
•
edited
Support for Android armv7 and aarch64 target triples in python build scripts (build + packaging)
--androidbuild parameter works as always (arm-linux-androideabi still the default)./mach build --release --androidNew compilation modes for android
./mach build --release --target=arm-linux-androideabi./mach build --release --target=armv7-linux-androideabi./mach build --release --target=aarch64-linux-androidSee #11921. When all crates are ready we'll switch default android compilations to
armv7-linux-androideabitarget triple../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is