Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the serialization of image-orientation property #16782

Merged
merged 1 commit into from May 9, 2017
Merged

Fix the serialization of image-orientation property #16782

merged 1 commit into from May 9, 2017

Conversation

@chenpighead
Copy link
Contributor

chenpighead commented May 9, 2017 •
edited

Gecko bug: Bug 1363295

This change is Reviewable
@chenpighead
stylo: Fix the serialization of image-orientation property. r=heycam
Loading status checks…
1c8e6eb 
Gecko bug: Bug 1363295
@highfive
Copy link

highfive commented May 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_box.mako.rs
  • @emilio: components/style/properties/longhand/inherited_box.mako.rs
@highfive
Copy link

highfive commented May 9, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@chenpighead
Copy link
Contributor Author

chenpighead commented May 9, 2017

@bors-servo r? @heycam
@highfive highfive assigned heycam and unassigned Manishearth May 9, 2017
@nox nox changed the title stylo: Fix the serialization of image-orientation property. r=heycam Fix the serialization of image-orientation property May 9, 2017
@nox
Copy link
Member

nox commented May 9, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

📌 Commit 1c8e6eb has been approved by nox
@highfive highfive assigned nox and unassigned heycam May 9, 2017
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⌛ Testing commit 1c8e6eb with merge 996d16006f1d9b99f557154a0b1c5fcb84290ac5...
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented May 9, 2017

@bors-servo: retry
#16783
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⌛ Testing commit 1c8e6eb with merge f93771e...
bors-servo added a commit that referenced this pull request May 9, 2017
@bors-servo
Auto merge of #16782 - chenpighead:stylo-serialization-of-image-orien…
Loading status checks…
f93771e 
…tation, r=nox

Fix the serialization of image-orientation property

Gecko bug: Bug 1363295

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16782)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - android
@jdm
Copy link
Member

jdm commented May 9, 2017

@bors-servo: retry

  • cross3 is broken
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, windows-msvc-dev are reusable. Rebuilding only android, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - android
@nox
Copy link
Member

nox commented May 9, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - android
@wafflespeanut
Copy link
Member

wafflespeanut commented May 9, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⌛ Testing commit 1c8e6eb with merge a05427f...
bors-servo added a commit that referenced this pull request May 9, 2017
@bors-servo
Auto merge of #16782 - chenpighead:stylo-serialization-of-image-orien…
Loading status checks…
a05427f 
…tation, r=nox

Fix the serialization of image-orientation property

Gecko bug: [Bug 1363295](https://bugzilla.mozilla.org/show_bug.cgi?id=1363295)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16782)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - mac-dev-unit
@jdm
Copy link
Member

jdm commented May 9, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only android, mac-dev-unit, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: nox
Pushing a05427f to master...
@bors-servo bors-servo merged commit 1c8e6eb into servo:master May 9, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@chenpighead @highfive @nox @bors-servo @jdm @wafflespeanut @heycam @Manishearth
You can’t perform that action at this time.