Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of counters function. #16791

Merged
merged 1 commit into from May 10, 2017
Merged

Conversation

@upsuper
Copy link
Member

upsuper commented May 10, 2017

This would fix several failures in Gecko's test.


This change is Reviewable

@highfive
Copy link

highfive commented May 10, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/counters.mako.rs
  • @emilio: components/style/properties/longhand/counters.mako.rs
@highfive
Copy link

highfive commented May 10, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented May 10, 2017

r? @heycam

@highfive highfive assigned heycam and unassigned glennw May 10, 2017
@heycam
Copy link
Member

heycam commented May 10, 2017

r=me

@bors-servo delegate+

@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2017

✌️ @upsuper can now approve this pull request

@upsuper
Copy link
Member Author

upsuper commented May 10, 2017

@bors-servo r=heycam

This just need annotation update in Gecko side, so we can land it anytime (and hope someone would be available to update the expectation).

@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2017

📌 Commit 512c2e9 has been approved by heycam

@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2017

Testing commit 512c2e9 with merge 4fe3854...

bors-servo added a commit that referenced this pull request May 10, 2017
Fix serialization of counters function.

This would fix several failures in Gecko's test.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16791)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2017

💔 Test failed - mac-dev-unit

@upsuper
Copy link
Member Author

upsuper commented May 10, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2017

Testing commit 512c2e9 with merge bd3ebf2...

bors-servo added a commit that referenced this pull request May 10, 2017
Fix serialization of counters function.

This would fix several failures in Gecko's test.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16791)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing bd3ebf2 to master...

@bors-servo bors-servo merged commit 512c2e9 into servo:master May 10, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:counters-fix branch May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.