Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Propagate quirks mode information from Gecko to Servo #16819

Merged
merged 1 commit into from May 14, 2017

Conversation

Projects
None yet
6 participants
@canaltinova
Copy link
Member

commented May 11, 2017

r=bholley in bugzilla


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1360488

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 11, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/data.rs, components/style/gecko_bindings/sugar/mod.rs, components/style/build_gecko.rs, components/style/gecko/wrapper.rs, components/style/gecko_bindings/sugar/ns_compatibility.rs and 1 more
  • @emilio: components/style/gecko/data.rs, components/style/gecko_bindings/sugar/mod.rs, components/style/build_gecko.rs, components/style/gecko/wrapper.rs, ports/geckolib/glue.rs and 2 more
@highfive

This comment has been minimized.

Copy link

commented May 11, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 11, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 11, 2017

📌 Commit 85fd153 has been approved by bholley

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

@bors-servo r-
(Needs coordinated landing. r-'ing because couldn't find anyone to push the m-c part. Feel free to land :) )

@bholley

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

File a bug to get L3 access, and I'll vouch for you? https://www.mozilla.org/en-US/about/governance/policies/commit/

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

☔️ The latest upstream changes (presumably #16802) made this pull request unmergeable. Please resolve the merge conflicts.

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

@bholley filed a bug, thanks!

@canaltinova canaltinova force-pushed the canaltinova:quirk-mode branch from 85fd153 to bf0054f May 12, 2017

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

📌 Commit bf0054f has been approved by bholley

@canaltinova canaltinova force-pushed the canaltinova:quirk-mode branch from bf0054f to 21dd713 May 12, 2017

@canaltinova canaltinova force-pushed the canaltinova:quirk-mode branch from 21dd713 to a329491 May 12, 2017

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

📌 Commit a329491 has been approved by bholley

@canaltinova canaltinova force-pushed the canaltinova:quirk-mode branch from a329491 to 267f317 May 12, 2017

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

Oops, forgot bindings.
@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

📌 Commit 267f317 has been approved by bholley

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 13, 2017

@bors-servo r-
ugh, there are lots of PRs in the homu queue and I won't be here to watch this.

@canaltinova

This comment has been minimized.

Copy link
Member Author

commented May 13, 2017

@bors-servo r=bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

📌 Commit 267f317 has been approved by bholley

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

⌛️ Testing commit 267f317 with merge f23dd17...

bors-servo added a commit that referenced this pull request May 13, 2017

Auto merge of #16819 - canaltinova:quirk-mode, r=bholley
stylo: Propagate quirks mode information from Gecko to Servo

r=bholley in bugzilla

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1360488](https://bugzilla.mozilla.org/show_bug.cgi?id=1360488)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16819)
<!-- Reviewable:end -->
@emilio

This comment has been minimized.

Copy link
Member

commented May 13, 2017

@bors-servo r-

Sorry @canaltinova, but I won't have time to land it right now :(.

@@ -80,7 +80,7 @@ pub struct Stylist {
viewport_constraints: Option<ViewportConstraints>,

/// If true, the quirks-mode stylesheet is applied.
quirks_mode: QuirksMode,
pub quirks_mode: QuirksMode,

This comment has been minimized.

Copy link
@emilio

emilio May 13, 2017

Member

If you have the time, while you're here, could you make an accessor instead of just making the field public?

@canaltinova canaltinova force-pushed the canaltinova:quirk-mode branch from 267f317 to c54d255 May 13, 2017

@emilio

This comment has been minimized.

Copy link
Member

commented May 14, 2017

@bors-servo r=bholley,emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2017

📌 Commit c54d255 has been approved by bholley,emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2017

⌛️ Testing commit c54d255 with merge 94ac822...

bors-servo added a commit that referenced this pull request May 14, 2017

Auto merge of #16819 - canaltinova:quirk-mode, r=bholley,emilio
stylo: Propagate quirks mode information from Gecko to Servo

r=bholley in bugzilla

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1360488](https://bugzilla.mozilla.org/show_bug.cgi?id=1360488)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16819)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: bholley,emilio
Pushing 94ac822 to master...

@bors-servo bors-servo merged commit c54d255 into servo:master May 14, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@canaltinova canaltinova deleted the canaltinova:quirk-mode branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.