Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo-side change stylesheet_set entry unique_id to u64 #16844

Merged
merged 1 commit into from May 13, 2017

Conversation

Projects
None yet
7 participants
@bradwerth
Copy link
Contributor

commented May 12, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1363572
https://reviewboard.mozilla.org/r/138092/


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 12, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheet_set.rs
  • @emilio: ports/geckolib/glue.rs, components/style/stylesheet_set.rs
@highfive

This comment has been minimized.

Copy link

commented May 12, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bradwerth

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

@bradwerth: 🔑 Insufficient privileges: Not in reviewers

@highfive highfive assigned heycam and unassigned metajack May 12, 2017

@bradwerth

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2017

@bors-servo r=metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

@bradwerth: 🔑 Insufficient privileges: Not in reviewers

@highfive highfive assigned metajack and unassigned heycam May 12, 2017

@metajack

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

📌 Commit 9c35a03 has been approved by heycam

@highfive highfive assigned heycam and unassigned metajack May 12, 2017

Bug 1363572 Part 1: Servo-side change stylesheet_set entry unique_id …
…to u64.

MozReview-Commit-ID: 2QZGCbN9xc8
@jdm

This comment has been minimized.

Copy link
Member

commented May 12, 2017

@bors-servo: r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

📌 Commit dbb638e has been approved by heycam

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 12, 2017

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

✌️ @bradwerth can now approve this pull request

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

⌛️ Testing commit dbb638e with merge 8e4aa0d...

bors-servo added a commit that referenced this pull request May 13, 2017

Auto merge of #16844 - bradwerth:stylesheet64, r=heycam
Servo-side change stylesheet_set entry unique_id to u64

https://bugzilla.mozilla.org/show_bug.cgi?id=1363572
https://reviewboard.mozilla.org/r/138092/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16844)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

💔 Test failed - mac-dev-unit

@bradwerth

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #16829
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

📌 Commit dbb638e has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

⌛️ Testing commit dbb638e with merge b80d4ac...

bors-servo added a commit that referenced this pull request May 13, 2017

Auto merge of #16844 - bradwerth:stylesheet64, r=heycam
Servo-side change stylesheet_set entry unique_id to u64

https://bugzilla.mozilla.org/show_bug.cgi?id=1363572
https://reviewboard.mozilla.org/r/138092/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16844)
<!-- Reviewable:end -->

@hiikezoe hiikezoe referenced this pull request May 13, 2017

Merged

Allow all numeric values for SMIL values #16851

3 of 3 tasks complete
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing b80d4ac to master...

@bors-servo bors-servo merged commit dbb638e into servo:master May 13, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bradwerth bradwerth deleted the bradwerth:stylesheet64 branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.