Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRenamed BrowsingContext to WindowProxy in script. #16845
Merged
Conversation
highfive
commented
May 12, 2017
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 12, 2017
|
|
|
cc @jdm @cbrewster |
| @@ -34,8 +34,7 @@ DOMInterfaces = { | |||
| }, | |||
|
|
|||
| 'WindowProxy' : { | |||
| 'nativeType': 'BrowsingContext', | |||
| 'path': 'dom::browsingcontext::BrowsingContext', | |||
| 'path': 'dom::windowproxy::WindowProxy', | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asajeffrey
May 12, 2017
Author
Member
I tried removing it and got:
error[E0432]: unresolved import `dom::types::WindowProxy`
--> /home/ajeffrey/github/asajeffrey/servo/target/debug/build/script-dcc60cde0df0c3a0/out/Bindings/DissimilarOriginWindowBinding.rs:339:5
|
339 | use dom::types::WindowProxy;
| ^^^^^^^^^^^^^^^^^^^^^^^ no `WindowProxy` in `dom::types`
error[E0432]: unresolved import `dom::types::WindowProxy`
--> /home/ajeffrey/github/asajeffrey/servo/target/debug/build/script-dcc60cde0df0c3a0/out/Bindings/HTMLIFrameElementBinding.rs:342:5
|
342 | use dom::types::WindowProxy;
| ^^^^^^^^^^^^^^^^^^^^^^^ no `WindowProxy` in `dom::types`
error[E0432]: unresolved import `dom::types::WindowProxy`
--> /home/ajeffrey/github/asajeffrey/servo/target/debug/build/script-dcc60cde0df0c3a0/out/Bindings/WindowBinding.rs:647:5
|
647 | use dom::types::WindowProxy;
| ^^^^^^^^^^^^^^^^^^^^^^^ no `WindowProxy` in `dom::types`
This comment has been minimized.
This comment has been minimized.
|
Otherwise this looks good to me. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 13, 2017
Renamed BrowsingContext to WindowProxy in script. <!-- Please describe your changes on the following line: --> Renamed `script::dom::BrowsingContext` to `script::dom::WindowProxy`. The browsing context is mostly maintained in the constellation, not in script. It would be nice to rename `constellation::Frame` to `constellation::BrowsingContext`, but that will be very confusing if there are two `BrowsingContext` types. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because renamings aren't externally visible <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16845) <!-- Reviewable:end -->
|
|
This was referenced May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMay 12, 2017
•
edited by larsbergstrom
Renamed
script::dom::BrowsingContexttoscript::dom::WindowProxy.The browsing context is mostly maintained in the constellation, not in script. It would be nice to rename
constellation::Frametoconstellation::BrowsingContext, but that will be very confusing if there are twoBrowsingContexttypes../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is