Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the hashless color quirk (fixes #15341) #16858

Merged
merged 1 commit into from May 17, 2017

Conversation

@nox
Copy link
Member

commented May 14, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 14, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/values/specified/color.rs, components/style/lib.rs, components/style/properties/longhand/background.mako.rs, components/style/values/specified/mod.rs and 2 more
  • @emilio: components/style/Cargo.toml, components/style/values/specified/color.rs, components/style/lib.rs, components/style/properties/longhand/background.mako.rs, components/style/values/specified/mod.rs and 2 more
@highfive

This comment has been minimized.

Copy link

commented May 14, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member Author

commented May 14, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2017

⌛️ Trying commit e97e6de with merge 53cf7b6...

bors-servo added a commit that referenced this pull request May 14, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2017

💔 Test failed - linux-rel-wpt

@nox nox force-pushed the nox:quirks branch from e97e6de to a86a512 May 16, 2017
@nox

This comment has been minimized.

Copy link
Member Author

commented May 16, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

⌛️ Trying commit a86a512 with merge ec9cd68...

bors-servo added a commit that referenced this pull request May 16, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

💔 Test failed - windows-msvc-dev

@nox

This comment has been minimized.

Copy link
Member Author

commented May 16, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

⌛️ Trying commit a86a512 with merge 292ac4e...

bors-servo added a commit that referenced this pull request May 16, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

💔 Test failed - windows-msvc-dev

@nox nox force-pushed the nox:quirks branch from a86a512 to 8699d25 May 16, 2017
@nox nox force-pushed the nox:quirks branch from 8699d25 to 965da2e May 16, 2017
@nox

This comment has been minimized.

Copy link
Member Author

commented May 16, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

⌛️ Trying commit 965da2e with merge 3b7763b...

bors-servo added a commit that referenced this pull request May 16, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

💔 Test failed - windows-msvc-dev

@nox nox force-pushed the nox:quirks branch from 965da2e to e4959aa May 16, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

⌛️ Trying commit e4959aa with merge 8098e7d...

bors-servo added a commit that referenced this pull request May 16, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

💥 Test timed out

@nox

This comment has been minimized.

Copy link
Member Author

commented May 16, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

⌛️ Trying commit e4959aa with merge fd0ee0e...

bors-servo added a commit that referenced this pull request May 16, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented May 16, 2017

The bizarre crash output is a symptom of #16898.

@nox nox force-pushed the nox:quirks branch from e4959aa to 9964b32 May 17, 2017
@nox

This comment has been minimized.

Copy link
Member Author

commented May 17, 2017

Live reviewing over IRC.

@bors-servo r=SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

📌 Commit 9964b32 has been approved by SimonSapin

@nox

This comment has been minimized.

Copy link
Member Author

commented May 17, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

⌛️ Testing commit 9964b32 with merge 5622c2a...

bors-servo added a commit that referenced this pull request May 17, 2017
Implement the hashless color quirk (fixes #15341)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16858)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: SimonSapin
Pushing 5622c2a to master...

@bors-servo bors-servo merged commit 9964b32 into servo:master May 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request May 17, 2017
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 17, 2017
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request May 18, 2017
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
MozReview-Commit-ID: IPhvKtncKGU

UltraBlame original commit: 7e04198f7bb6bb3b018e82e58bc5baaea14972ef
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
MozReview-Commit-ID: IPhvKtncKGU

UltraBlame original commit: 7e04198f7bb6bb3b018e82e58bc5baaea14972ef
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
MozReview-Commit-ID: IPhvKtncKGU

UltraBlame original commit: 7e04198f7bb6bb3b018e82e58bc5baaea14972ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.